Replace QString::fromAscii by QString::fromLatin1 #356
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QString::fromAscii is deprecated in recent versions of QT, should be replaced by QString::fromLatin1: see https://wiki.qt.io/Transition_from_Qt_4.x_to_Qt5
Fix warning [-Wreorder]: reorder initializers in TransferMetaData::TransferMetaData as they match declarations order.
Fix deprecations warnings
Fix various conversion warnings, between long long, double, unsigned short and so on...
Author
|
I propose a few fixes for various compilation warnings (mainly -Wconversion and -Wdeprecated). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
QString::fromAscii is deprecated in recent versions of Qt (Qt5), should be replaced by
QString::fromLatin1: see https://wiki.qt.io/Transition_from_Qt_4.x_to_Qt5