Skip to content

Conversation

@melitele
Copy link
Contributor

@melitele melitele commented Dec 7, 2025

The intent of this PR is to make it easier to manipulate the expected bundle size. Instead of hardcoding the value of expected bundle size in the test file it puts in in a JSON file.

It also introduces one method of updating the expected bundle size automatically by running a build test with the parameter UPDATE set to true:

UPDATE=true npm run test-build -- min.test.ts

Launch Checklist

  • Confirm your changes do not include backports from Mapbox projects (unless with compliant license) - if you are not sure about this, please ask!
  • Briefly describe the changes in this PR.

@codecov
Copy link

codecov bot commented Dec 7, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.41%. Comparing base (53df3ad) to head (6014bc2).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6823   +/-   ##
=======================================
  Coverage   92.41%   92.41%           
=======================================
  Files         288      288           
  Lines       23807    23807           
  Branches     5055     5055           
=======================================
  Hits        22002    22002           
  Misses       1805     1805           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Collaborator

@HarelM HarelM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

THANKS!!

@HarelM HarelM enabled auto-merge (squash) December 7, 2025 08:40
@HarelM HarelM merged commit ef805d2 into maplibre:main Dec 7, 2025
42 of 43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants