Fix clipboard in xterm #1833
Merged
Fix clipboard in xterm #1833
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pascalbreuninger
approved these changes
Apr 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes copy and pasting from the desktop app logs.
The issue was a known xterm limitation in that ctrl +c is mapped to the terminals key handlers. Previously we relied on document.execCommand("copy") but this is deprecated in web view. Looking at the dependency GH issues xtermjs/xterm.js#2478 and xtermjs/xterm.js#292 a user offered an alternative solution which is to use
attachCustomKeyEventHandlerand return false on Ctrl + C to prevent the terminal key binding being used on ctrl +c.https://developer.mozilla.org/en-US/docs/Web/API/Document/execCommand