fix: runtime error andd images issues #7235
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: saurabhraghuvanshii <[email protected]>
Contributor
Author
|
I'm testing for production, as it working for local but not for production |
Signed-off-by: saurabhraghuvanshii <[email protected]>
Contributor
|
@saurabhraghuvanshii Currently the build seems to be broken because the Footer slice is trying to read the current URL using a hook that only works inside a router, and slices don’t live inside that router context during the HTML build. |
Contributor
Author
|
@Fireentity it faling after new changes, I'm looking for fix |
Member
|
Gents, here's a fix for a similar issue. Let's pick a methodology and consistently implement - https://github.com/layer5io/layer5/pull/7237/files |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes #7118
Notes for Reviewers
Signed commits