-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Migrate Handbook Pages into MDX Collections #7223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Migrate Handbook Pages into MDX Collections #7223
Conversation
Signed-off-by: Rajesh-Nagarajan-11 <[email protected]>
Signed-off-by: Rajesh-Nagarajan-11 <[email protected]>
Signed-off-by: Rajesh-Nagarajan-11 <[email protected]>
Signed-off-by: Rajesh-Nagarajan-11 <[email protected]>
Signed-off-by: Rajesh-Nagarajan-11 <[email protected]>
Signed-off-by: Rajesh-Nagarajan-11 <[email protected]>
Signed-off-by: Rajesh-Nagarajan-11 <[email protected]>
Signed-off-by: Rajesh-Nagarajan-11 <[email protected]>
Signed-off-by: Rajesh-Nagarajan-11 <[email protected]>
Signed-off-by: Rajesh-Nagarajan-11 <[email protected]>
Signed-off-by: Rajesh-Nagarajan-11 <[email protected]>
Signed-off-by: Rajesh-Nagarajan-11 <[email protected]>
Signed-off-by: Rajesh-Nagarajan-11 <[email protected]>
Signed-off-by: Rajesh-Nagarajan-11 <[email protected]>
Signed-off-by: Rajesh-Nagarajan-11 <[email protected]>
Signed-off-by: Rajesh-Nagarajan-11 <[email protected]>
Signed-off-by: Rajesh-Nagarajan-11 <[email protected]>
Signed-off-by: Rajesh-Nagarajan-11 <[email protected]>
Signed-off-by: Rajesh-Nagarajan-11 <[email protected]>
Signed-off-by: Rajesh-Nagarajan-11 <[email protected]>
Signed-off-by: Rajesh-Nagarajan-11 <[email protected]>
Signed-off-by: Rajesh-Nagarajan-11 <[email protected]>
Signed-off-by: Rajesh-Nagarajan-11 <[email protected]>
Signed-off-by: Rajesh-Nagarajan-11 <[email protected]>
|
🚀 Preview for commit 0d7f1de at: https://6932f417e8593695c41da815--layer5.netlify.app |
|
@Rajesh-Nagarajan-11, this is great to see. Does this mean no more hardcoded navigation menu for the handbook? |
|
Yes @leecalcote no more hard-coded menu |
Signed-off-by: Rajesh-Nagarajan-11 <[email protected]>
|
🚀 Preview for commit 0c7ad82 at: https://6934313c680ce18435afb3c0--layer5.netlify.app |
Signed-off-by: Rajesh-Nagarajan-11 <[email protected]>
Signed-off-by: Rajesh-Nagarajan-11 <[email protected]>
|
🚀 Preview for commit ab65391 at: https://69343fdc7e978ab9651c8a74--layer5.netlify.app |
kishore08-07
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work @Rajesh-Nagarajan-11
LGTM
|
Great work @Rajesh-Nagarajan-11.🚀 |
Signed-off-by: Rajesh-Nagarajan-11 <[email protected]>
|
🚀 Preview for commit b820cf0 at: https://69344ef5bc13a9dc0dbfa1e5--layer5.netlify.app |
|
🚀 Preview for commit f75ad16 at: https://693471861e48342986c632ee--layer5.netlify.app |
| contents: | ||
| - id: 0 | ||
| link: "#About Layer5" | ||
| text: "About Layer5" | ||
| - id: 1 | ||
| link: "#Goals" | ||
| text: "Goals" | ||
| - id: 2 | ||
| link: "#Newcomer's Path" | ||
| text: "Newcomer's Path" | ||
| - id: 3 | ||
| link: "#Working on your issue" | ||
| text: "Working on your issue" | ||
| - id: 4 | ||
| link: "#While your issue is under review" | ||
| text: "While your issue is under review" | ||
| --- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
links are not working
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The link is not working on all pages that are using it. I think there might be an issue with the template definition — please look into it.
| Layer5 is dedicated to empowering engineers and supporting the open source community that create them. Learn more about Layer5 and connect with the community by following and engaging with us on our social media accounts. | ||
|
|
||
| <div> | ||
| <p className="channels-para"><img className="channels-img" src={twitter_icon} alt="twitter" /> <a href="https://x.com/layer5">@layer5</a>, <a href="https://x.com/mesheryio">@mesheryio</a> and <a href="https://x.com/kanvas-new">@kanvas-new</a></p> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| <p className="channels-para"><img className="channels-img" src={twitter_icon} alt="twitter" /> <a href="https://x.com/layer5">@layer5</a>, <a href="https://x.com/mesheryio">@mesheryio</a> and <a href="https://x.com/kanvas-new">@kanvas-new</a></p> | |
| <p className="channels-para"><img className="channels-img" src={twitter_icon} alt="twitter" /> <a href="https://x.com/layer5">@layer5</a>, <a href="https://x.com/mesheryio">@mesheryio</a> and <a href="https://x.com/kanvas-new">@kanvas-new</a></p> |
https://x.com/kanvas-new
page doesn’t exist.
| @@ -0,0 +1,70 @@ | |||
| --- | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
file naming is incorrect
| @@ -0,0 +1,70 @@ | |||
| --- | |||
| title: "GitHub Organization" | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| title: "GitHub Organization" | |
| title: "GitHub Organization Membership" |
|
|
||
| the user experience of any of our projects, please share them with us. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| the user experience of any of our projects, please share them with us. | |
| the user experience of any of our projects, please share them with us. |
keep in one line, because of that there is line breaking on page
|
@Rajesh-Nagarajan-11 I noticed another issue with the current change. Clicking on items in the Table of Contents causes the page to reload, but it should navigate smoothly without reloading. |
Currently
Description
Notes for Reviewers
src/collections/handbookSigned commits