Skip to content

Conversation

@Priyankasaggu11929
Copy link
Member

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/access Define who has access to what via IAM bindings, role bindings, policy, etc. area/artifacts Issues or PRs related to the hosting of release artifacts for subprojects area/groups Google Groups management, code in groups/ area/infra Infrastructure management, infrastructure design, code in infra/ area/infra/gcp Issues or PRs related to Kubernetes GCP infrastructure area/registry.k8s.io Code in registry.k8s.io/ labels Dec 3, 2025
@k8s-ci-robot k8s-ci-robot added the area/terraform Terraform modules, testing them, writing more of them, code in infra/gcp/clusters/ label Dec 3, 2025
@k8s-ci-robot k8s-ci-robot requested a review from GenPage December 3, 2025 13:09
@k8s-ci-robot k8s-ci-robot added sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. sig/node Categorizes an issue or PR as relevant to SIG Node. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 3, 2025
@Priyankasaggu11929 Priyankasaggu11929 force-pushed the registry-node-readiness-controller branch 2 times, most recently from 81a2105 to f565e3d Compare December 3, 2025 13:47
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 3, 2025
@Priyankasaggu11929
Copy link
Member Author

/test pull-k8sio-cip

@ajaysundark
Copy link

/lgtm
/approve

Thanks for setting this up @Priyankasaggu11929!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 3, 2025
@ajaysundark
Copy link

/cc @BenTheElder @ameukam for k8s-infra

@k8s-ci-robot
Copy link
Contributor

@ajaysundark: GitHub didn't allow me to request PR reviews from the following users: for, k8s-infra.

Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @BenTheElder @ameukam for k8s-infra

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@BenTheElder
Copy link
Member

/cc @BenTheElder @ameukam for k8s-infra

I'm not a K8s Infra TL anymore and I can't /approve:

k8s.io/OWNERS

Lines 6 to 8 in 87b2549

emeritus_approvers:
- bartsmykla
- BenTheElder

@BenTheElder
Copy link
Member

/uncc

@k8s-ci-robot k8s-ci-robot removed the request for review from BenTheElder December 3, 2025 18:34
Comment on lines 168 to 171
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could use alias instead ? ([email protected])

@ameukam
Copy link
Member

ameukam commented Dec 4, 2025

@Priyankasaggu11929 Sorry it's not properly documented but the distribution group is a requirement to set up the staging repo. So you want to split this PR.

@Priyankasaggu11929 Priyankasaggu11929 force-pushed the registry-node-readiness-controller branch from 4d50bf9 to f25719e Compare December 4, 2025 08:52
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 4, 2025
@k8s-ci-robot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

@Priyankasaggu11929
Copy link
Member Author

@Priyankasaggu11929 Sorry it's not properly documented but the distribution group is a requirement to set up the staging repo. So you want to split this PR.

Thank you @ameukam.

Let me send a PR splitting the distribution creation.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ajaysundark, Priyankasaggu11929
Once this PR has been reviewed and has the lgtm label, please assign xmudrii for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Priyankasaggu11929
Copy link
Member Author

Let me send a PR splitting the distribution creation.

addressed in https://github.com/kubernetes/k8s.io/pull/8838/files

@Priyankasaggu11929
Copy link
Member Author

/test pull-k8sio-cip

@@ -0,0 +1,49 @@
# google group for gcr.io/k8s-staging-node-readiness-controller is [email protected]
registries:
- name: gcr.io/k8s-staging-node-readiness-controller
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- name: gcr.io/k8s-staging-node-readiness-controller
- name: us-central1-docker.pkg.dev/k8s-staging-images/node-readiness-controller

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed all review comments in latest commit refresh. Thanks for pointing, @ameukam. 🙏

Just for my understanding - what is the difference between using the above 2 registries? when to use which one?

(Thanks again in advance!)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are different products in Google Cloud (which seems to be hosting k8s bits too).
gcr is deprecated, and the pkg.dev repositories are from Artifact Registry. fyi, https://docs.cloud.google.com/artifact-registry/docs/transition/transition-from-gcr

@Priyankasaggu11929 Priyankasaggu11929 force-pushed the registry-node-readiness-controller branch from 36a650e to 3e1df4b Compare December 4, 2025 11:35
@ameukam
Copy link
Member

ameukam commented Dec 5, 2025

atlantis plan

@k8s-infra-ci-robot
Copy link
Contributor

Ran Plan for dir: infra/gcp/terraform/k8s-staging-images workspace: default

Show Output
Note: Objects have changed outside of Terraform

Terraform detected the following changes made outside of Terraform since the
last "terraform apply" which may have affected this plan:

  # module.artifact_registry["agent-sandbox"].google_artifact_registry_repository.repo has changed
~ resource "google_artifact_registry_repository" "repo" {
        id                     = "projects/k8s-staging-images/locations/us-central1/repositories/agent-sandbox"
        name                   = "agent-sandbox"
      ~ update_time            = "2025-11-25T17:13:20.737743Z" -> "2025-12-03T17:47:47.786136Z"
        # (12 unchanged attributes hidden)

        # (1 unchanged block hidden)
    }

  # module.artifact_registry["cloud-provider-kind"].google_artifact_registry_repository.repo has changed
~ resource "google_artifact_registry_repository" "repo" {
        id                     = "projects/k8s-staging-images/locations/us-central1/repositories/cloud-provider-kind"
        name                   = "cloud-provider-kind"
      ~ update_time            = "2025-11-25T10:49:07.105086Z" -> "2025-12-03T20:52:45.658435Z"
        # (12 unchanged attributes hidden)

        # (1 unchanged block hidden)
    }

  # module.artifact_registry["contributor-site"].google_artifact_registry_repository.repo has changed
~ resource "google_artifact_registry_repository" "repo" {
        id                     = "projects/k8s-staging-images/locations/us-central1/repositories/contributor-site"
        name                   = "contributor-site"
      ~ update_time            = "2025-11-19T17:27:23.971093Z" -> "2025-11-28T13:36:48.408576Z"
        # (12 unchanged attributes hidden)

        # (1 unchanged block hidden)
    }

  # module.artifact_registry["csi-vsphere"].google_artifact_registry_repository.repo has changed
~ resource "google_artifact_registry_repository" "repo" {
        id                     = "projects/k8s-staging-images/locations/us-central1/repositories/csi-vsphere"
        name                   = "csi-vsphere"
      ~ update_time            = "2025-11-25T15:41:31.178744Z" -> "2025-12-05T08:30:26.734274Z"
        # (12 unchanged attributes hidden)

        # (1 unchanged block hidden)
    }

  # module.artifact_registry["dra-example-driver"].google_artifact_registry_repository.repo has changed
~ resource "google_artifact_registry_repository" "repo" {
        id                     = "projects/k8s-staging-images/locations/us-central1/repositories/dra-example-driver"
        name                   = "dra-example-driver"
      ~ update_time            = "2025-10-30T07:32:59.319403Z" -> "2025-11-26T08:38:14.493887Z"
        # (12 unchanged attributes hidden)

        # (1 unchanged block hidden)
    }

  # module.artifact_registry["gateway-api-inference-extension"].google_artifact_registry_repository.repo has changed
~ resource "google_artifact_registry_repository" "repo" {
        id                     = "projects/k8s-staging-images/locations/us-central1/repositories/gateway-api-inference-extension"
        name                   = "gateway-api-inference-extension"
      ~ update_time            = "2025-11-25T17:23:18.944644Z" -> "2025-12-05T07:19:10.295005Z"
        # (12 unchanged attributes hidden)

        # (1 unchanged block hidden)
    }

  # module.artifact_registry["ingress-nginx"].google_artifact_registry_repository.repo has changed
~ resource "google_artifact_registry_repository" "repo" {
        id                     = "projects/k8s-staging-images/locations/us-central1/repositories/ingress-nginx"
        name                   = "ingress-nginx"
      ~ update_time            = "2025-11-25T10:48:15.203365Z" -> "2025-12-04T02:30:00.915900Z"
        # (12 unchanged attributes hidden)

        # (1 unchanged block hidden)
    }

  # module.artifact_registry["jobset"].google_artifact_registry_repository.repo has changed
~ resource "google_artifact_registry_repository" "repo" {
        id                     = "projects/k8s-staging-images/locations/us-central1/repositories/jobset"
        name                   = "jobset"
      ~ update_time            = "2025-11-25T02:31:32.437238Z" -> "2025-12-05T02:52:50.275678Z"
        # (12 unchanged attributes hidden)

        # (1 unchanged block hidden)
    }

  # module.artifact_registry["kro"].google_artifact_registry_repository.repo has changed
~ resource "google_artifact_registry_repository" "repo" {
        id                     = "projects/k8s-staging-images/locations/us-central1/repositories/kro"
        name                   = "kro"
      ~ update_time            = "2025-11-25T08:53:28.664873Z" -> "2025-12-05T00:23:50.703858Z"
        # (12 unchanged attributes hidden)

        # (1 unchanged block hidden)
    }

  # module.artifact_registry["kueue"].google_artifact_registry_repository.repo has changed
~ resource "google_artifact_registry_repository" "repo" {
        id                     = "projects/k8s-staging-images/locations/us-central1/repositories/kueue"
        name                   = "kueue"
      ~ update_time            = "2025-11-25T16:52:50.949330Z" -> "2025-12-05T08:49:18.590704Z"
        # (12 unchanged attributes hidden)

        # (1 unchanged block hidden)
    }

  # module.artifact_registry["lws"].google_artifact_registry_repository.repo has changed
~ resource "google_artifact_registry_repository" "repo" {
        id                     = "projects/k8s-staging-images/locations/us-central1/repositories/lws"
        name                   = "lws"
      ~ update_time            = "2025-11-25T09:03:33.956982Z" -> "2025-12-04T18:38:57.243873Z"
        # (12 unchanged attributes hidden)

        # (1 unchanged block hidden)
    }

  # module.artifact_registry["minikube"].google_artifact_registry_repository.repo has changed
~ resource "google_artifact_registry_repository" "repo" {
        id                     = "projects/k8s-staging-images/locations/us-central1/repositories/minikube"
        name                   = "minikube"
      ~ update_time            = "2025-08-28T19:30:36.700112Z" -> "2025-12-04T23:16:07.166169Z"
        # (12 unchanged attributes hidden)

        # (1 unchanged block hidden)
    }


Unless you have made equivalent changes to your configuration, or ignored the
relevant attributes using ignore_changes, the following plan may include
actions to undo or respond to these changes.

─────────────────────────────────────────────────────────────────────────────

Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
+ create
~ update in-place

Terraform will perform the following actions:

  # module.artifact_registry["agent-sandbox"].google_project_iam_member.roles["roles/artifactregistry.serviceAgent"] will be created
+ resource "google_project_iam_member" "roles" {
      + etag    = (known after apply)
      + id      = (known after apply)
      + member  = (known after apply)
      + project = "k8s-staging-images"
      + role    = "roles/artifactregistry.serviceAgent"
    }

  # module.artifact_registry["agent-sandbox"].google_project_service_identity.artifact_registry_sa will be created
+ resource "google_project_service_identity" "artifact_registry_sa" {
      + email   = (known after apply)
      + id      = (known after apply)
      + member  = (known after apply)
      + project = "k8s-staging-images"
      + service = "artifactregistry.googleapis.com"
    }

  # module.artifact_registry["aws-encryption-provider"].google_project_iam_member.roles["roles/artifactregistry.serviceAgent"] will be created
+ resource "google_project_iam_member" "roles" {
      + etag    = (known after apply)
      + id      = (known after apply)
      + member  = (known after apply)
      + project = "k8s-staging-images"
      + role    = "roles/artifactregistry.serviceAgent"
    }

  # module.artifact_registry["aws-encryption-provider"].google_project_service_identity.artifact_registry_sa will be created
+ resource "google_project_service_identity" "artifact_registry_sa" {
      + email   = (known after apply)
      + id      = (known after apply)
      + member  = (known after apply)
      + project = "k8s-staging-images"
      + service = "artifactregistry.googleapis.com"
    }

  # module.artifact_registry["charts"].google_project_iam_member.roles["roles/artifactregistry.serviceAgent"] will be created
+ resource "google_project_iam_member" "roles" {
      + etag    = (known after apply)
      + id      = (known after apply)
      + member  = (known after apply)
      + project = "k8s-staging-images"
      + role    = "roles/artifactregistry.serviceAgent"
    }

  # module.artifact_registry["charts"].google_project_service_identity.artifact_registry_sa will be created
+ resource "google_project_service_identity" "artifact_registry_sa" {
      + email   = (known after apply)
      + id      = (known after apply)
      + member  = (known after apply)
      + project = "k8s-staging-images"
      + service = "artifactregistry.googleapis.com"
    }

  # module.artifact_registry["cloud-provider-kind"].google_project_iam_member.roles["roles/artifactregistry.serviceAgent"] will be created
+ resource "google_project_iam_member" "roles" {
      + etag    = (known after apply)
      + id      = (known after apply)
      + member  = (known after apply)
      + project = "k8s-staging-images"
      + role    = "roles/artifactregistry.serviceAgent"
    }

  # module.artifact_registry["cloud-provider-kind"].google_project_service_identity.artifact_registry_sa will be created
+ resource "google_project_service_identity" "artifact_registry_sa" {
      + email   = (known after apply)
      + id      = (known after apply)
      + member  = (known after apply)
      + project = "k8s-staging-images"
      + service = "artifactregistry.googleapis.com"
    }

  # module.artifact_registry["cluster-capacity"].google_project_iam_member.roles["roles/artifactregistry.serviceAgent"] will be created
+ resource "google_project_iam_member" "roles" {
      + etag    = (known after apply)
      + id      = (known after apply)
      + member  = (known after apply)
      + project = "k8s-staging-images"
      + role    = "roles/artifactregistry.serviceAgent"
    }

  # module.artifact_registry["cluster-capacity"].google_project_service_identity.artifact_registry_sa will be created
+ resource "google_project_service_identity" "artifact_registry_sa" {
      + email   = (known after apply)
      + id      = (known after apply)
      + member  = (known after apply)
      + project = "k8s-staging-images"
      + service = "artifactregistry.googleapis.com"
    }

  # module.artifact_registry["contributor-site"].google_project_iam_member.roles["roles/artifactregistry.serviceAgent"] will be created
+ resource "google_project_iam_member" "roles" {
      + etag    = (known after apply)
      + id      = (known after apply)
      + member  = (known after apply)
      + project = "k8s-staging-images"
      + role    = "roles/artifactregistry.serviceAgent"
    }

  # module.artifact_registry["contributor-site"].google_project_service_identity.artifact_registry_sa will be created
+ resource "google_project_service_identity" "artifact_registry_sa" {
      + email   = (known after apply)
      + id      = (known after apply)
      + member  = (known after apply)
      + project = "k8s-staging-images"
      + service = "artifactregistry.googleapis.com"
    }

  # module.artifact_registry["csi-vsphere"].google_project_iam_member.roles["roles/artifactregistry.serviceAgent"] will be created
+ resource "google_project_iam_member" "roles" {
      + etag    = (known after apply)
      + id      = (known after apply)
      + member  = (known after apply)
      + project = "k8s-staging-images"
      + role    = "roles/artifactregistry.serviceAgent"
    }

  # module.artifact_registry["csi-vsphere"].google_project_service_identity.artifact_registry_sa will be created
+ resource "google_project_service_identity" "artifact_registry_sa" {
      + email   = (known after apply)
      + id      = (known after apply)
      + member  = (known after apply)
      + project = "k8s-staging-images"
      + service = "artifactregistry.googleapis.com"
    }

  # module.artifact_registry["dra-driver-cpu"].google_project_iam_member.roles["roles/artifactregistry.serviceAgent"] will be created
+ resource "google_project_iam_member" "roles" {
      + etag    = (known after apply)
      + id      = (known after apply)
      + member  = (known after apply)
      + project = "k8s-staging-images"
      + role    = "roles/artifactregistry.serviceAgent"
    }

  # module.artifact_registry["dra-driver-cpu"].google_project_service_identity.artifact_registry_sa will be created
+ resource "google_project_service_identity" "artifact_registry_sa" {
      + email   = (known after apply)
      + id      = (known after apply)
      + member  = (known after apply)
      + project = "k8s-staging-images"
      + service = "artifactregistry.googleapis.com"
    }

  # module.artifact_registry["dra-example-driver"].google_project_iam_member.roles["roles/artifactregistry.serviceAgent"] will be created
+ resource "google_project_iam_member" "roles" {
      + etag    = (known after apply)
      + id      = (known after apply)
      + member  = (known after apply)
      + project = "k8s-staging-images"
      + role    = "roles/artifactregistry.serviceAgent"
    }

  # module.artifact_registry["dra-example-driver"].google_project_service_identity.artifact_registry_sa will be created
+ resource "google_project_service_identity" "artifact_registry_sa" {
      + email   = (known after apply)
      + id      = (known after apply)
      + member  = (known after apply)
      + project = "k8s-staging-images"
      + service = "artifactregistry.googleapis.com"
    }

  # module.artifact_registry["etcd"].google_project_iam_member.roles["roles/artifactregistry.serviceAgent"] will be created
+ resource "google_project_iam_member" "roles" {
      + etag    = (known after apply)
      + id      = (known after apply)
      + member  = (known after apply)
      + project = "k8s-staging-images"
      + role    = "roles/artifactregistry.serviceAgent"
    }

  # module.artifact_registry["etcd"].google_project_service_identity.artifact_registry_sa will be created
+ resource "google_project_service_identity" "artifact_registry_sa" {
      + email   = (known after apply)
      + id      = (known after apply)
      + member  = (known after apply)
      + project = "k8s-staging-images"
      + service = "artifactregistry.googleapis.com"
    }

  # module.artifact_registry["etcd-manager"].google_project_iam_member.roles["roles/artifactregistry.serviceAgent"] will be created
+ resource "google_project_iam_member" "roles" {
      + etag    = (known after apply)
      + id      = (known after apply)
      + member  = (known after apply)
      + project = "k8s-staging-images"
      + role    = "roles/artifactregistry.serviceAgent"
    }

  # module.artifact_registry["etcd-manager"].google_project_service_identity.artifact_registry_sa will be created
+ resource "google_project_service_identity" "artifact_registry_sa" {
      + email   = (known after apply)
      + id      = (known after apply)
      + member  = (known after apply)
      + project = "k8s-staging-images"
      + service = "artifactregistry.googleapis.com"
    }

  # module.artifact_registry["gateway-api-inference-extension"].google_project_iam_member.roles["roles/artifactregistry.serviceAgent"] will be created
+ resource "google_project_iam_member" "roles" {
      + etag    = (known after apply)
      + id      = (known after apply)
      + member  = (known after apply)
      + project = "k8s-staging-images"
      + role    = "roles/artifactregistry.serviceAgent"
    }

  # module.artifact_registry["gateway-api-inference-extension"].google_project_service_identity.artifact_registry_sa will be created
+ resource "google_project_service_identity" "artifact_registry_sa" {
      + email   = (known after apply)
      + id      = (known after apply)
      + member  = (known after apply)
      + project = "k8s-staging-images"
      + service = "artifactregistry.googleapis.com"
    }

  # module.artifact_registry["headlamp"].google_project_iam_member.roles["roles/artifactregistry.serviceAgent"] will be created
+ resource "google_project_iam_member" "roles" {
      + etag    = (known after apply)
      + id      = (known after apply)
      + member  = (known after apply)
      + project = "k8s-staging-images"
      + role    = "roles/artifactregistry.serviceAgent"
    }

  # module.artifact_registry["headlamp"].google_project_service_identity.artifact_registry_sa will be created
+ resource "google_project_service_identity" "artifact_registry_sa" {
      + email   = (known after apply)
      + id      = (known after apply)
      + member  = (known after apply)
      + project = "k8s-staging-images"
      + service = "artifactregistry.googleapis.com"
    }

  # module.artifact_registry["inference-perf"].google_project_iam_member.roles["roles/artifactregistry.serviceAgent"] will be created
+ resource "google_project_iam_member" "roles" {
      + etag    = (known after apply)
      + id      = (known after apply)
      + member  = (known after apply)
      + project = "k8s-staging-images"
      + role    = "roles/artifactregistry.serviceAgent"
    }

  # module.artifact_registry["inference-perf"].google_project_service_identity.artifact_registry_sa will be created
+ resource "google_project_service_identity" "artifact_registry_sa" {
      + email   = (known after apply)
      + id      = (known after apply)
      + member  = (known after apply)
      + project = "k8s-staging-images"
      + service = "artifactregistry.googleapis.com"
    }

  # module.artifact_registry["infra-tools"].google_project_iam_member.roles["roles/artifactregistry.serviceAgent"] will be created
+ resource "google_project_iam_member" "roles" {
      + etag    = (known after apply)
      + id      = (known after apply)
      + member  = (known after apply)
      + project = "k8s-staging-images"
      + role    = "roles/artifactregistry.serviceAgent"
    }

  # module.artifact_registry["infra-tools"].google_project_service_identity.artifact_registry_sa will be created
+ resource "google_project_service_identity" "artifact_registry_sa" {
      + email   = (known after apply)
      + id      = (known after apply)
      + member  = (known after apply)
      + project = "k8s-staging-images"
      + service = "artifactregistry.googleapis.com"
    }

  # module.artifact_registry["ingate"].google_project_iam_member.roles["roles/artifactregistry.serviceAgent"] will be created
+ resource "google_project_iam_member" "roles" {
      + etag    = (known after apply)
      + id      = (known after apply)
      + member  = (known after apply)
      + project = "k8s-staging-images"
      + role    = "roles/artifactregistry.serviceAgent"
    }

  # module.artifact_registry["ingate"].google_project_service_identity.artifact_registry_sa will be created
+ resource "google_project_service_identity" "artifact_registry_sa" {
      + email   = (known after apply)
      + id      = (known after apply)
      + member  = (known after apply)
      + project = "k8s-staging-images"
      + service = "artifactregistry.googleapis.com"
    }

  # module.artifact_registry["ingress-nginx"].google_project_iam_member.roles["roles/artifactregistry.serviceAgent"] will be created
+ resource "google_project_iam_member" "roles" {
      + etag    = (known after apply)
      + id      = (known after apply)
      + member  = (known after apply)
      + project = "k8s-staging-images"
      + role    = "roles/artifactregistry.serviceAgent"
    }

  # module.artifact_registry["ingress-nginx"].google_project_service_identity.artifact_registry_sa will be created
+ resource "google_project_service_identity" "artifact_registry_sa" {
      + email   = (known after apply)
      + id      = (known after apply)
      + member  = (known after apply)
      + project = "k8s-staging-images"
      + service = "artifactregistry.googleapis.com"
    }

  # module.artifact_registry["jobset"].google_project_iam_member.roles["roles/artifactregistry.serviceAgent"] will be created
+ resource "google_project_iam_member" "roles" {
      + etag    = (known after apply)
      + id      = (known after apply)
      + member  = (known after apply)
      + project = "k8s-staging-images"
      + role    = "roles/artifactregistry.serviceAgent"
    }

  # module.artifact_registry["jobset"].google_project_service_identity.artifact_registry_sa will be created
+ resource "google_project_service_identity" "artifact_registry_sa" {
      + email   = (known after apply)
      + id      = (known after apply)
      + member  = (known after apply)
      + project = "k8s-staging-images"
      + service = "artifactregistry.googleapis.com"
    }

  # module.artifact_registry["karpenter-cluster-api"].google_project_iam_member.roles["roles/artifactregistry.serviceAgent"] will be created
+ resource "google_project_iam_member" "roles" {
      + etag    = (known after apply)
      + id      = (known after apply)
      + member  = (known after apply)
      + project = "k8s-staging-images"
      + role    = "roles/artifactregistry.serviceAgent"
    }

  # module.artifact_registry["karpenter-cluster-api"].google_project_service_identity.artifact_registry_sa will be created
+ resource "google_project_service_identity" "artifact_registry_sa" {
      + email   = (known after apply)
      + id      = (known after apply)
      + member  = (known after apply)
      + project = "k8s-staging-images"
      + service = "artifactregistry.googleapis.com"
    }

  # module.artifact_registry["kind"].google_project_iam_member.roles["roles/artifactregistry.serviceAgent"] will be created
+ resource "google_project_iam_member" "roles" {
      + etag    = (known after apply)
      + id      = (known after apply)
      + member  = (known after apply)
      + project = "k8s-staging-images"
      + role    = "roles/artifactregistry.serviceAgent"
    }

  # module.artifact_registry["kind"].google_project_service_identity.artifact_registry_sa will be created
+ resource "google_project_service_identity" "artifact_registry_sa" {
      + email   = (known after apply)
      + id      = (known after apply)
      + member  = (known after apply)
      + project = "k8s-staging-images"
      + service = "artifactregistry.googleapis.com"
    }

  # module.artifact_registry["kro"].google_project_iam_member.roles["roles/artifactregistry.serviceAgent"] will be created
+ resource "google_project_iam_member" "roles" {
      + etag    = (known after apply)
      + id      = (known after apply)
      + member  = (known after apply)
      + project = "k8s-staging-images"
      + role    = "roles/artifactregistry.serviceAgent"
    }

  # module.artifact_registry["kro"].google_project_service_identity.artifact_registry_sa will be created
+ resource "google_project_service_identity" "artifact_registry_sa" {
      + email   = (known after apply)
      + id      = (known after apply)
      + member  = (known after apply)
      + project = "k8s-staging-images"
      + service = "artifactregistry.googleapis.com"
    }

  # module.artifact_registry["kubemark"].google_project_iam_member.roles["roles/artifactregistry.serviceAgent"] will be created
+ resource "google_project_iam_member" "roles" {
      + etag    = (known after apply)
      + id      = (known after apply)
      + member  = (known after apply)
      + project = "k8s-staging-images"
      + role    = "roles/artifactregistry.serviceAgent"
    }

  # module.artifact_registry["kubemark"].google_project_service_identity.artifact_registry_sa will be created
+ resource "google_project_service_identity" "artifact_registry_sa" {
      + email   = (known after apply)
      + id      = (known after apply)
      + member  = (known after apply)
      + project = "k8s-staging-images"
      + service = "artifactregistry.googleapis.com"
    }

  # module.artifact_registry["kubernetes"].google_project_iam_member.roles["roles/artifactregistry.serviceAgent"] will be created
+ resource "google_project_iam_member" "roles" {
      + etag    = (known after apply)
      + id      = (known after apply)
      + member  = (known after apply)
      + project = "k8s-staging-images"
      + role    = "roles/artifactregistry.serviceAgent"
    }

  # module.artifact_registry["kubernetes"].google_project_service_identity.artifact_registry_sa will be created
+ resource "google_project_service_identity" "artifact_registry_sa" {
      + email   = (known after apply)
      + id      = (known after apply)
      + member  = (known after apply)
      + project = "k8s-staging-images"
      + service = "artifactregistry.googleapis.com"
    }

  # module.artifact_registry["kueue"].google_project_iam_member.roles["roles/artifactregistry.serviceAgent"] will be created
+ resource "google_project_iam_member" "roles" {
      + etag    = (known after apply)
      + id      = (known after apply)
      + member  = (known after apply)
      + project = "k8s-staging-images"
      + role    = "roles/artifactregistry.serviceAgent"
    }

  # module.artifact_registry["kueue"].google_project_service_identity.artifact_registry_sa will be created
+ resource "google_project_service_identity" "artifact_registry_sa" {
      + email   = (known after apply)
      + id      = (known after apply)
      + member  = (known after apply)
      + project = "k8s-staging-images"
      + service = "artifactregistry.googleapis.com"
    }

  # module.artifact_registry["lws"].google_project_iam_member.roles["roles/artifactregistry.serviceAgent"] will be created
+ resource "google_project_iam_member" "roles" {
      + etag    = (known after apply)
      + id      = (known after apply)
      + member  = (known after apply)
      + project = "k8s-staging-images"
      + role    = "roles/artifactregistry.serviceAgent"
    }

  # module.artifact_registry["lws"].google_project_service_identity.artifact_registry_sa will be created
+ resource "google_project_service_identity" "artifact_registry_sa" {
      + email   = (known after apply)
      + id      = (known after apply)
      + member  = (known after apply)
      + project = "k8s-staging-images"
      + service = "artifactregistry.googleapis.com"
    }

  # module.artifact_registry["maintainer-tools"].google_project_iam_member.roles["roles/artifactregistry.serviceAgent"] will be created
+ resource "google_project_iam_member" "roles" {
      + etag    = (known after apply)
      + id      = (known after apply)
      + member  = (known after apply)
      + project = "k8s-staging-images"
      + role    = "roles/artifactregistry.serviceAgent"
    }

  # module.artifact_registry["maintainer-tools"].google_project_service_identity.artifact_registry_sa will be created
+ resource "google_project_service_identity" "artifact_registry_sa" {
      + email   = (known after apply)
      + id      = (known after apply)
      + member  = (known after apply)
      + project = "k8s-staging-images"
      + service = "artifactregistry.googleapis.com"
    }

  # module.artifact_registry["minikube"].google_project_iam_member.roles["roles/artifactregistry.serviceAgent"] will be created
+ resource "google_project_iam_member" "roles" {
      + etag    = (known after apply)
      + id      = (known after apply)
      + member  = (known after apply)
      + project = "k8s-staging-images"
      + role    = "roles/artifactregistry.serviceAgent"
    }

  # module.artifact_registry["minikube"].google_project_service_identity.artifact_registry_sa will be created
+ resource "google_project_service_identity" "artifact_registry_sa" {
      + email   = (known after apply)
      + id      = (known after apply)
      + member  = (known after apply)
      + project = "k8s-staging-images"
      + service = "artifactregistry.googleapis.com"
    }

  # module.artifact_registry["node-readiness-controller"].google_artifact_registry_repository.repo will be created
+ resource "google_artifact_registry_repository" "repo" {
      + cleanup_policy_dry_run = false
      + create_time            = (known after apply)
      + effective_labels       = {
          + "goog-terraform-provisioned" = "true"
        }
      + format                 = "DOCKER"
      + id                     = (known after apply)
      + location               = "us-central1"
      + mode                   = "STANDARD_REPOSITORY"
      + name                   = (known after apply)
      + project                = "k8s-staging-images"
      + repository_id          = "node-readiness-controller"
      + terraform_labels       = {
          + "goog-terraform-provisioned" = "true"
        }
      + update_time            = (known after apply)

      + cleanup_policies {
          + action = "DELETE"
          + id     = "delete-images-older-than-90-days"

          + condition {
              + older_than            = "7776000s"
              + package_name_prefixes = []
              + tag_prefixes          = []
              + tag_state             = "ANY"
              + version_name_prefixes = []
                # (1 unchanged attribute hidden)
            }
        }
    }

  # module.artifact_registry["node-readiness-controller"].google_artifact_registry_repository_iam_member.readers["allUsers"] will be created
+ resource "google_artifact_registry_repository_iam_member" "readers" {
      + etag       = (known after apply)
      + id         = (known after apply)
      + location   = "us-central1"
      + member     = "allUsers"
      + project    = "k8s-staging-images"
      + repository = (known after apply)
      + role       = "roles/artifactregistry.reader"
    }

  # module.artifact_registry["node-readiness-controller"].google_artifact_registry_repository_iam_member.writers["group:[email protected]"] will be created
+ resource "google_artifact_registry_repository_iam_member" "writers" {
      + etag       = (known after apply)
      + id         = (known after apply)
      + location   = "us-central1"
      + member     = "group:[email protected]"
      + project    = "k8s-staging-images"
      + repository = (known after apply)
      + role       = "roles/artifactregistry.writer"
    }

  # module.artifact_registry["node-readiness-controller"].google_project_iam_member.roles["roles/artifactregistry.serviceAgent"] will be created
+ resource "google_project_iam_member" "roles" {
      + etag    = (known after apply)
      + id      = (known after apply)
      + member  = (known after apply)
      + project = "k8s-staging-images"
      + role    = "roles/artifactregistry.serviceAgent"
    }

  # module.artifact_registry["node-readiness-controller"].google_project_service_identity.artifact_registry_sa will be created
+ resource "google_project_service_identity" "artifact_registry_sa" {
      + email   = (known after apply)
      + id      = (known after apply)
      + member  = (known after apply)
      + project = "k8s-staging-images"
      + service = "artifactregistry.googleapis.com"
    }

  # module.artifact_registry["secrets-store-sync"].google_project_iam_member.roles["roles/artifactregistry.serviceAgent"] will be created
+ resource "google_project_iam_member" "roles" {
      + etag    = (known after apply)
      + id      = (known after apply)
      + member  = (known after apply)
      + project = "k8s-staging-images"
      + role    = "roles/artifactregistry.serviceAgent"
    }

  # module.artifact_registry["secrets-store-sync"].google_project_service_identity.artifact_registry_sa will be created
+ resource "google_project_service_identity" "artifact_registry_sa" {
      + email   = (known after apply)
      + id      = (known after apply)
      + member  = (known after apply)
      + project = "k8s-staging-images"
      + service = "artifactregistry.googleapis.com"
    }

  # module.artifact_registry["test-infra"].google_project_iam_member.roles["roles/artifactregistry.serviceAgent"] will be created
+ resource "google_project_iam_member" "roles" {
      + etag    = (known after apply)
      + id      = (known after apply)
      + member  = (known after apply)
      + project = "k8s-staging-images"
      + role    = "roles/artifactregistry.serviceAgent"
    }

  # module.artifact_registry["test-infra"].google_project_service_identity.artifact_registry_sa will be created
+ resource "google_project_service_identity" "artifact_registry_sa" {
      + email   = (known after apply)
      + id      = (known after apply)
      + member  = (known after apply)
      + project = "k8s-staging-images"
      + service = "artifactregistry.googleapis.com"
    }

  # module.iam.google_project_iam_binding.project_iam_authoritative["default--roles/viewer"] will be updated in-place
~ resource "google_project_iam_binding" "project_iam_authoritative" {
        id      = "k8s-staging-images/roles/viewer"
      ~ members = [
          + "group:[email protected]",
            # (28 unchanged elements hidden)
        ]
        # (3 unchanged attributes hidden)
    }

Plan: 63 to add, 1 to change, 0 to destroy.
  • ▶️ To apply this plan, comment:
    atlantis apply -d infra/gcp/terraform/k8s-staging-images
  • 🚮 To delete this plan and lock, click here
  • 🔁 To plan this project again, comment:
    atlantis plan -d infra/gcp/terraform/k8s-staging-images

Note: Objects have changed outside of Terraform
Plan: 63 to add, 1 to change, 0 to destroy.


  • ⏩ To apply all unapplied plans from this Pull Request, comment:
    atlantis apply
  • 🚮 To delete all plans and locks from this Pull Request, comment:
    atlantis unlock

@ameukam
Copy link
Member

ameukam commented Dec 5, 2025

@upodroid Looks like a service identity for AR will be added to all the AR repos. Is it expected ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/access Define who has access to what via IAM bindings, role bindings, policy, etc. area/artifacts Issues or PRs related to the hosting of release artifacts for subprojects area/groups Google Groups management, code in groups/ area/infra/gcp Issues or PRs related to Kubernetes GCP infrastructure area/infra Infrastructure management, infrastructure design, code in infra/ area/registry.k8s.io Code in registry.k8s.io/ area/terraform Terraform modules, testing them, writing more of them, code in infra/gcp/clusters/ cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. sig/node Categorizes an issue or PR as relevant to SIG Node. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants