Skip to content

docs: default value of allowCRDDeletion is false, which may cause confusion. #811

@kennygt51

Description

@kennygt51

Documentation Issue

Location:
Getting Started / examples
https://kro.run/docs/getting-started/Installation
https://kro.run/docs/getting-started/deploy-a-resource-graph-definition

Current State:
When deleting the RGD, CRDs deployed by the RGD are not deleted automatically.
Therefore, when deleting a RGD, users need to manually delete the CRDs deployed by the RGD.

This is because the default value of allowCRDDeletion is false.
ref:

flag.BoolVar(&allowCRDDeletion, "allow-crd-deletion", false, "allow kro to delete CRDs")

Getting Started installation guide doesn't include this setting.
I think a lot of users may become confused during testing.
Myself as well, As a user, I experienced some confusion while working through some examples.

Suggested Changes:
Consider one of the following approaches:

  • Change the default option for allowCRDDeletion to true
  • Add a note to the Getting Started guide and some README of examples:
    • "allowCRDDeletion is set to false by default, CRDs must be manually deleted"

Once the necessary corrections are identified and the policy is decided, I will take care of it on my side.

Metadata

Metadata

Assignees

No one assigned

    Labels

    kind/documentationCategorizes issue or PR as related to documentation.triage/acceptedIndicates an issue or PR is ready to be actively worked on.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions