-
Notifications
You must be signed in to change notification settings - Fork 2.8k
Open
Labels
kind/bugCategorizes issue or PR as related to a bug.Categorizes issue or PR as related to a bug.
Description
What happened:
zone_type_filter includes github.com/aws/aws-sdk-go-v2/service/route53/types for https://github.com/kubernetes-sigs/external-dns/blob/master/provider/zone_type_filter.go#L54
What you expected to happen:
Probably this logic should be moved into the aws-specific provider package https://github.com/kubernetes-sigs/external-dns/tree/master/provider/aws
How to reproduce it (as minimally and precisely as possible):
Anything else we need to know?:
This means, that every provider (internal or external) that makes use of the provider package adds a dependency on aws-sdk-v2 (or a subpart of it).
Environment:
- External-DNS version (use
external-dns --version): v0.20.0 - DNS provider: n/a
- Others: n/a
Metadata
Metadata
Assignees
Labels
kind/bugCategorizes issue or PR as related to a bug.Categorizes issue or PR as related to a bug.