Skip to content

Drop aws-specifics from provider/zone_type_filter.go #5983

@mrueg

Description

@mrueg

What happened:
zone_type_filter includes github.com/aws/aws-sdk-go-v2/service/route53/types for https://github.com/kubernetes-sigs/external-dns/blob/master/provider/zone_type_filter.go#L54

What you expected to happen:
Probably this logic should be moved into the aws-specific provider package https://github.com/kubernetes-sigs/external-dns/tree/master/provider/aws

How to reproduce it (as minimally and precisely as possible):

Anything else we need to know?:
This means, that every provider (internal or external) that makes use of the provider package adds a dependency on aws-sdk-v2 (or a subpart of it).

Environment:

  • External-DNS version (use external-dns --version): v0.20.0
  • DNS provider: n/a
  • Others: n/a

Metadata

Metadata

Assignees

No one assigned

    Labels

    kind/bugCategorizes issue or PR as related to a bug.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions