Changed how json is retrieved from kwargs, updated tests [aiohttp] #573
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkwi
changed the title
kevin1024
force-pushed
the
master
branch
3 times, most recently
from
df3997c to
34d5384
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #507
Current implementation works only when we send requests using
session.request("POST", url, json={'a': 1}).When
session.post(url, **kwargs)is used,kwargswill look like this:{'data': None, 'json': {'a': 1}}When using
session.post/session.put/session.put,'data'will always be present inkwargs(source)This is where
data = kwargs.get("data", kwargs.get("json"))retrievesNonevalue and why request body ends up to be empty in saved cassette.I also updated tests to cover this issue.