fix(condition): fix in and not in condition if value is empty

Author: jaronnie

condition/condition.go

@@ -90,8 +90,16 @@ func buildExpr(cond *sqlbuilder.Cond, field string, operator Operator, value any
 	case LessEqualThan:
 		return cond.LessEqualThan(field, value)
 	case In:
+		if len(castx.ToSlice(value)) == 0 {
+			// if value is empty, force placeholder nil to avoid sql error
+			return cond.In(field, nil)
+		}
 		return cond.In(field, castx.ToSlice(value)...)
 	case NotIn:
+		if len(castx.ToSlice(value)) == 0 {
+			// if value is empty, force placeholder nil to avoid sql error
+			return cond.NotIn(field, nil)
+		}
 		return cond.NotIn(field, castx.ToSlice(value)...)
 	case Like:
 		return cond.Like(field, value)

condition/condition_test.go

@@ -169,3 +169,31 @@ func TestRawWhereClause(t *testing.T) {
 	fmt.Println(sql)
 	fmt.Println(args)
 }
+
+func TestChain_In(t *testing.T) {
+	t.Run("test", func(t *testing.T) {
+		sqlbuilder.DefaultFlavor = sqlbuilder.MySQL
+		sb := sqlbuilder.NewSelectBuilder().Select("id").From("users")
+		builder := Select(*sb, Condition{
+			Field:    "id",
+			Operator: In,
+			Value:    []int{1},
+		})
+
+		sql, args := builder.Build()
+		fmt.Println(sql, args)
+	})
+
+	t.Run("test2", func(t *testing.T) {
+		sqlbuilder.DefaultFlavor = sqlbuilder.MySQL
+		sb := sqlbuilder.NewSelectBuilder().Select("id").From("users")
+		builder := Select(*sb, Condition{
+			Field:    "id",
+			Operator: In,
+			Value:    []int{},
+		})
+
+		sql, args := builder.Build()
+		fmt.Println(sql, args)
+	})
+}