From 8a6b7bcba6657406c78d08b8ec71790abcb37843 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Micha=C5=82=20Go=C5=82e=CC=A8biowski-Owczarek?= Date: Tue, 23 Sep 2025 23:04:48 +0200 Subject: [PATCH 1/2] Repo: Update both `version` fields in `package-lock.json` `package-lock.json` versions 2 & 3 keep `version` in two fields - a top-level `version` one and a deep `packages[ "" ].version` one. Update both. --- lib/repo.js | 3 +++ 1 file changed, 3 insertions(+) diff --git a/lib/repo.js b/lib/repo.js index 0c4a7f6..dbd6514 100644 --- a/lib/repo.js +++ b/lib/repo.js @@ -149,6 +149,9 @@ Release.define( { console.log( "Updating " + fileName + "..." ); var json = Release._readJSON( fileName ); json.version = version; + if ( json?.packages[ "" ]?.version ) { + json.packages[ "" ].version = version; + } Release._writeJSON( fileName, json ); }, From 55750e95deb32403e4fdc6014708f343c50375bc Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Micha=C5=82=20Go=C5=82e=CC=A8biowski-Owczarek?= Date: Fri, 19 Dec 2025 11:53:41 +0100 Subject: [PATCH 2/2] fixup! Repo: Update both `version` fields in `package-lock.json` --- lib/repo.js | 22 +++------------------- 1 file changed, 3 insertions(+), 19 deletions(-) diff --git a/lib/repo.js b/lib/repo.js index dbd6514..a3d9d89 100644 --- a/lib/repo.js +++ b/lib/repo.js @@ -6,7 +6,7 @@ var fs = require( "fs" ), module.exports = function( Release ) { Release.define( { - _jsonFiles: [ "package.json", "package-lock.json", "bower.json" ], + _jsonFiles: [ "package.json", "package-lock.json" ], _cloneRepo: function() { var releaseDependencies, projectRelease; @@ -142,23 +142,8 @@ Release.define( { Release._writeJSON( "package.json", json ); }, - _versionJSON: function( fileName, version ) { - if ( !fs.existsSync( Release.dir.repo + "/" + fileName ) ) { - return; - } - console.log( "Updating " + fileName + "..." ); - var json = Release._readJSON( fileName ); - json.version = version; - if ( json?.packages[ "" ]?.version ) { - json.packages[ "" ].version = version; - } - Release._writeJSON( fileName, json ); - }, - _setVersion: function( version ) { - Release._jsonFiles.forEach( function( file ) { - Release._versionJSON( file, version ); - } ); + Release.exec( "npm version " + version + " --no-git-tag-version" ); }, _getVersions: function() { @@ -275,8 +260,7 @@ Release.define( { "Error checking out " + Release.branch + " branch." ); // Update only canonical version - Release._versionJSON( "package.json", Release.nextVersion ); - Release._versionJSON( "package-lock.json", Release.nextVersion ); + Release._setVersion( Release.nextVersion ); console.log( "Committing version update..." ); Release.exec( "git commit -am \"Build: Updating the " + Release.branch +