Skip to content

Conversation

@riyueguang
Copy link
Contributor

@riyueguang riyueguang commented Apr 12, 2025

  • PR Description
    fix function name in comment

  • Please check if the PR fulfills these requirements

  • Cheatsheets are up-to-date (run go generate ./...)
  • Code has been formatted (see here)
  • Tests have been added/updated (see here for the integration test guide)
  • Text is internationalised (see here)
  • If a new UserConfig entry was added, make sure it can be hot-reloaded (see here)
  • Docs have been updated if necessary
  • You've read through your own file changes for silly mistakes etc

@riyueguang
Copy link
Contributor Author

friendly ping

@stefanhaller
Copy link
Collaborator

Thanks; please rebase onto master and resolve conflicts, and I'll merge.

Long-term I'd rather like to remove the function names from the comments altogether, this would avoid this class of problem.

@riyueguang
Copy link
Contributor Author

@stefanhaller Thank you for your reply.

I have resolved the conflicts and rebased with the latest code.

Please review it again.

@stefanhaller stefanhaller added the maintenance For refactorings, CI changes, tests, version bumping, etc label Dec 6, 2025
@stefanhaller stefanhaller merged commit 0fc8cb3 into jesseduffield:master Dec 6, 2025
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintenance For refactorings, CI changes, tests, version bumping, etc

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants