Skip to content

Conversation

@EmeraldShift
Copy link
Contributor

@EmeraldShift EmeraldShift commented Oct 10, 2025

Re-introduce a PR (original: #132) to add a -share flag when both MAGIC_TRACE_SHARE_DOC and MAGIC_TRACE_SHARE_COMMAND are provided. It's available as an alternative to -serve, and both cannot be provided in the same invocation.

For example, with

MAGIC_TRACE_SHARE_DOC=" Share the trace." MAGIC_TRACE_SHARE_COMMAND=/usr/bin/echo magic-trace run -help

I see the flag in the CLI help:

  [-share]                   . Share the trace.

and with a real program to run, the command is invoked, and I see the trace file name echoed into my terminal.

@cgaebel cgaebel merged commit 57ba36d into janestreet:master Oct 25, 2025
2 checks passed
@cgaebel
Copy link
Contributor

cgaebel commented Oct 25, 2025

lgtm, ty

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants