[storage][cassandra] Make v1 `SpanWriter` reusable for v2 #7699

Manik2708 · 2025-12-05T12:10:38Z

Which problem is this PR solving?

Fixes a part of: Upgrade Storage Backends to V2 Storage API #6458

Description of the changes

This marks the first step to upgrade cassandra backend to v2. The v1 CoreSpanWriter is seperated from v1 SpanWriter

How was this change tested?

Unit and Integration tests

Checklist

I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md
I have signed all commits
I have added unit tests for the new functionality
I have run lint and test steps successfully
- for jaeger: make lint test
- for jaeger-ui: npm run lint and npm run test

Signed-off-by: Manik Mehta <[email protected]>

Manik2708 · 2025-12-05T12:12:42Z

internal/storage/v1/cassandra/spanstore/writer.go

 	return s.operationNamesWriter(operation)
 }
+
+func epochMicrosecondsAsTime(ts int64) time.Time {


I am unsure about this. Should I use the conversion available in model? As then linter is giving an error of overflowing as we need to convert int32 to uint32 and inside that function unit32 is again converted to int32

codecov · 2025-12-05T12:19:33Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.55%. Comparing base (3003a5c) to head (ee4c5ba).
⚠️ Report is 19 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #7699      +/-   ##
==========================================
+ Coverage   96.54%   96.55%   +0.01%     
==========================================
  Files         384      385       +1     
  Lines       19511    19531      +20     
==========================================
+ Hits        18837    18859      +22     
+ Misses        489      487       -2     
  Partials      185      185

Flag	Coverage Δ
badger_v1	`8.79% <0.00%> (-0.02%)`	⬇️
badger_v2	`1.72% <0.00%> (-0.01%)`	⬇️
cassandra-4.x-v1-manual	`12.68% <75.00%> (+0.14%)`	⬆️
cassandra-4.x-v2-auto	`1.71% <0.00%> (-0.01%)`	⬇️
cassandra-4.x-v2-manual	`1.71% <0.00%> (-0.01%)`	⬇️
cassandra-5.x-v1-manual	`12.68% <75.00%> (+0.14%)`	⬆️
cassandra-5.x-v2-auto	`1.71% <0.00%> (-0.01%)`	⬇️
cassandra-5.x-v2-manual	`1.71% <0.00%> (-0.01%)`	⬇️
clickhouse	`1.65% <0.00%> (-0.01%)`	⬇️
elasticsearch-6.x-v1	`16.70% <0.00%> (-0.04%)`	⬇️
elasticsearch-7.x-v1	`16.73% <0.00%> (-0.04%)`	⬇️
elasticsearch-8.x-v1	`16.88% <0.00%> (-0.04%)`	⬇️
elasticsearch-8.x-v2	`1.72% <0.00%> (-0.01%)`	⬇️
elasticsearch-9.x-v2	`1.72% <0.00%> (-0.01%)`	⬇️
grpc_v1	`10.75% <0.00%> (-0.03%)`	⬇️
grpc_v2	`1.72% <0.00%> (-0.01%)`	⬇️
kafka-3.x-v1	`10.22% <0.00%> (-0.03%)`	⬇️
kafka-3.x-v2	`1.72% <0.00%> (-0.01%)`	⬇️
memory_v2	`1.72% <0.00%> (-0.01%)`	⬇️
opensearch-1.x-v1	`16.77% <0.00%> (-0.04%)`	⬇️
opensearch-2.x-v1	`16.77% <0.00%> (-0.04%)`	⬇️
opensearch-2.x-v2	`1.72% <0.00%> (-0.01%)`	⬇️
opensearch-3.x-v2	`1.72% <0.00%> (-0.01%)`	⬇️
query	`1.72% <0.00%> (-0.01%)`	⬇️
tailsampling-processor	`0.49% <0.00%> (-0.01%)`	⬇️
unittests	`95.42% <77.77%> (-0.03%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

github-actions · 2025-12-05T12:21:01Z

Metrics Comparison Summary

Total changes across all snapshots: 53

Detailed changes per snapshot

summary_metrics_snapshot_cassandra

📊 Metrics Diff Summary

Total Changes: 53

🆕 Added: 0 metrics
❌ Removed: 53 metrics
🔄 Modified: 0 metrics

❌ Removed Metrics

http_server_request_body_size_bytes (18 variants)

View diff sample

-http_server_request_body_size_bytes{http_request_method="GET",http_response_status_code="503",le="+Inf",network_protocol_name="http",network_protocol_version="1.1",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp",otel_scope_schema_url="",otel_scope_version="0.63.0",server_address="localhost",server_port="13133",url_scheme="http"}
-http_server_request_body_size_bytes{http_request_method="GET",http_response_status_code="503",le="0",network_protocol_name="http",network_protocol_version="1.1",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp",otel_scope_schema_url="",otel_scope_version="0.63.0",server_address="localhost",server_port="13133",url_scheme="http"}
-http_server_request_body_size_bytes{http_request_method="GET",http_response_status_code="503",le="10",network_protocol_name="http",network_protocol_version="1.1",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp",otel_scope_schema_url="",otel_scope_version="0.63.0",server_address="localhost",server_port="13133",url_scheme="http"}
-http_server_request_body_size_bytes{http_request_method="GET",http_response_status_code="503",le="100",network_protocol_name="http",network_protocol_version="1.1",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp",otel_scope_schema_url="",otel_scope_version="0.63.0",server_address="localhost",server_port="13133",url_scheme="http"}
-http_server_request_body_size_bytes{http_request_method="GET",http_response_status_code="503",le="1000",network_protocol_name="http",network_protocol_version="1.1",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp",otel_scope_schema_url="",otel_scope_version="0.63.0",server_address="localhost",server_port="13133",url_scheme="http"}
-http_server_request_body_size_bytes{http_request_method="GET",http_response_status_code="503",le="10000",network_protocol_name="http",network_protocol_version="1.1",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp",otel_scope_schema_url="",otel_scope_version="0.63.0",server_address="localhost",server_port="13133",url_scheme="http"}
-http_server_request_body_size_bytes{http_request_method="GET",http_response_status_code="503",le="25",network_protocol_name="http",network_protocol_version="1.1",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp",otel_scope_schema_url="",otel_scope_version="0.63.0",server_address="localhost",server_port="13133",url_scheme="http"}
...

- `http_server_request_duration_seconds` (17 variants)

View diff sample

-http_server_request_duration_seconds{http_request_method="GET",http_response_status_code="503",le="+Inf",network_protocol_name="http",network_protocol_version="1.1",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp",otel_scope_schema_url="",otel_scope_version="0.63.0",server_address="localhost",server_port="13133",url_scheme="http"}
-http_server_request_duration_seconds{http_request_method="GET",http_response_status_code="503",le="0.005",network_protocol_name="http",network_protocol_version="1.1",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp",otel_scope_schema_url="",otel_scope_version="0.63.0",server_address="localhost",server_port="13133",url_scheme="http"}
-http_server_request_duration_seconds{http_request_method="GET",http_response_status_code="503",le="0.01",network_protocol_name="http",network_protocol_version="1.1",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp",otel_scope_schema_url="",otel_scope_version="0.63.0",server_address="localhost",server_port="13133",url_scheme="http"}
-http_server_request_duration_seconds{http_request_method="GET",http_response_status_code="503",le="0.025",network_protocol_name="http",network_protocol_version="1.1",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp",otel_scope_schema_url="",otel_scope_version="0.63.0",server_address="localhost",server_port="13133",url_scheme="http"}
-http_server_request_duration_seconds{http_request_method="GET",http_response_status_code="503",le="0.05",network_protocol_name="http",network_protocol_version="1.1",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp",otel_scope_schema_url="",otel_scope_version="0.63.0",server_address="localhost",server_port="13133",url_scheme="http"}
-http_server_request_duration_seconds{http_request_method="GET",http_response_status_code="503",le="0.075",network_protocol_name="http",network_protocol_version="1.1",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp",otel_scope_schema_url="",otel_scope_version="0.63.0",server_address="localhost",server_port="13133",url_scheme="http"}
-http_server_request_duration_seconds{http_request_method="GET",http_response_status_code="503",le="0.1",network_protocol_name="http",network_protocol_version="1.1",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp",otel_scope_schema_url="",otel_scope_version="0.63.0",server_address="localhost",server_port="13133",url_scheme="http"}
...

- `http_server_response_body_size_bytes` (18 variants)

View diff sample

-http_server_response_body_size_bytes{http_request_method="GET",http_response_status_code="503",le="+Inf",network_protocol_name="http",network_protocol_version="1.1",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp",otel_scope_schema_url="",otel_scope_version="0.63.0",server_address="localhost",server_port="13133",url_scheme="http"}
-http_server_response_body_size_bytes{http_request_method="GET",http_response_status_code="503",le="0",network_protocol_name="http",network_protocol_version="1.1",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp",otel_scope_schema_url="",otel_scope_version="0.63.0",server_address="localhost",server_port="13133",url_scheme="http"}
-http_server_response_body_size_bytes{http_request_method="GET",http_response_status_code="503",le="10",network_protocol_name="http",network_protocol_version="1.1",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp",otel_scope_schema_url="",otel_scope_version="0.63.0",server_address="localhost",server_port="13133",url_scheme="http"}
-http_server_response_body_size_bytes{http_request_method="GET",http_response_status_code="503",le="100",network_protocol_name="http",network_protocol_version="1.1",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp",otel_scope_schema_url="",otel_scope_version="0.63.0",server_address="localhost",server_port="13133",url_scheme="http"}
-http_server_response_body_size_bytes{http_request_method="GET",http_response_status_code="503",le="1000",network_protocol_name="http",network_protocol_version="1.1",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp",otel_scope_schema_url="",otel_scope_version="0.63.0",server_address="localhost",server_port="13133",url_scheme="http"}
-http_server_response_body_size_bytes{http_request_method="GET",http_response_status_code="503",le="10000",network_protocol_name="http",network_protocol_version="1.1",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp",otel_scope_schema_url="",otel_scope_version="0.63.0",server_address="localhost",server_port="13133",url_scheme="http"}
-http_server_response_body_size_bytes{http_request_method="GET",http_response_status_code="503",le="25",network_protocol_name="http",network_protocol_version="1.1",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp",otel_scope_schema_url="",otel_scope_version="0.63.0",server_address="localhost",server_port="13133",url_scheme="http"}
...

➡️ View full metrics file

yurishkuro · 2025-12-05T16:05:02Z

I don't follow why there are business logic changes in this PR if the objective is just refactoring to make it reusable?

Manik2708 · 2025-12-05T16:13:29Z

I don't follow why there are business logic changes in this PR if the objective is just refactoring to make it reusable?

There are no business logic changes in this PR. It's just that we implemented CoreSpanWriter which accepts dbmodel.Span (very similar to Elasticsearch approach)

yurishkuro · 2025-12-06T02:56:53Z

There are no business logic changes in this PR. I

For example, this is removed. How is that not a business logic change?

tagFilter            dbmodel.TagFilter

Manik2708 · 2025-12-06T03:19:34Z

There are no business logic changes in this PR. I

For example, this is removed. How is that not a business logic change?
tagFilter            dbmodel.TagFilter

That is removed from CoreSpanWriter and added to SpanWriterV1. This is done because tagFilter is used for filtering tag from model.Span, which should not be the part of core writer but that of v1 writer

yurishkuro · 2025-12-06T03:21:12Z

which should not be the part of core writer but that of v1 writer

why?

Manik2708 · 2025-12-06T03:32:10Z

which should not be the part of core writer but that of v1 writer

why

tagFilter is used in this method:

jaeger/internal/storage/v1/cassandra/spanstore/writer.go

Line 210 in 865a396

for _, v := range dbmodel.GetAllUniqueTags(span, s.tagFilter) {

which is using model.Span, that means it is used for conversion of Tags to dbmodel.TagInsertion and conversion should be in v1 writer not in core writer

yurishkuro · 2025-12-06T04:32:26Z

filtering tags is not about conversion but about indexing or not indexing them in the db

Manik2708 · 2025-12-06T04:39:50Z

filtering tags is not about conversion but about indexing or not indexing them in the db

Yes but what we need is dbmodel.TagInsertion from model.Span.Tags. Should I try extracting TagInsertion from dbmodel.Span.Tags rather than from model.Span.Tags?

Manik2708 · 2025-12-06T04:41:41Z

filtering tags is not about conversion but about indexing or not indexing them in the db

Yes but what we need is dbmodel.TagInsertion from model.Span.Tags. Should I try extracting TagInsertion from dbmodel.Span.Tags rather than from model.Span.Tags?

As that would need to refactor the whole TagFilter interface. Should we do that?

yurishkuro · 2025-12-07T02:22:01Z

internal/storage/v1/cassandra/spanstore/dbmodel/model.go

+	float64Type  = "float64"
+	binaryType   = "binary"
+	spanKindKey  = "span.kind"
+	FirehoseFlag = int32(8)


this is not the same kind of constant, why group it with others?

Suggested change

FirehoseFlag = int32(8)

FirehoseFlag = int32(8)

yurishkuro · 2025-12-07T02:23:04Z

internal/storage/v1/cassandra/spanstore/writer.go

 	}

-	if span.Flags.IsFirehoseEnabled() {
+	if dbmodel.IsFirehoseEnabled(ds) {


this logic can be dropped altogether, there is no "firehose" bit in OTLP trace state flags.

yurishkuro · 2025-12-07T02:26:00Z

As that would need to refactor the whole TagFilter interface. Should we do that?

We can change that interface to work entirely on the dbmodel input.

Manik2708 · 2025-12-07T04:58:25Z

As that would need to refactor the whole TagFilter interface. Should we do that?

We can change that interface to work entirely on the dbmodel input.

@yurishkuro I was trying to refactor the TagFilter. The only problem is that, we have to implement Compare, Equal and AsString for db.KeyValue. This is not very hard but I just want to confirm whether should we implement them (we need them for sorting)

yurishkuro · 2025-12-07T13:36:25Z

it's fine

[cassandra] Make v1 SpanWriter reusable for v2

5b7ec24

Signed-off-by: Manik Mehta <[email protected]>

Manik2708 requested a review from a team as a code owner December 5, 2025 12:10

Manik2708 requested a review from joe-elliott December 5, 2025 12:10

Merge branch 'main' into cass-v2

ee4c5ba

dosubot bot added area/storage enhancement storage/cassandra labels Dec 5, 2025

Manik2708 commented Dec 5, 2025

View reviewed changes

yurishkuro reviewed Dec 7, 2025

View reviewed changes

Manik2708 mentioned this pull request Dec 7, 2025

[cassandra] Refactor TagFilter to accept dbmodel.Span #7707

Open

4 tasks

[storage][cassandra] Make v1 SpanWriter reusable for v2 #7699

Are you sure you want to change the base?

[storage][cassandra] Make v1 SpanWriter reusable for v2 #7699

Uh oh!

Conversation

Manik2708 commented Dec 5, 2025

Which problem is this PR solving?

Description of the changes

How was this change tested?

Checklist

Uh oh!

Manik2708 Dec 5, 2025

Choose a reason for hiding this comment

Uh oh!

codecov bot commented Dec 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

github-actions bot commented Dec 5, 2025

Metrics Comparison Summary

summary_metrics_snapshot_cassandra

📊 Metrics Diff Summary

❌ Removed Metrics

Uh oh!

yurishkuro commented Dec 5, 2025

Uh oh!

Manik2708 commented Dec 5, 2025

Uh oh!

yurishkuro commented Dec 6, 2025

Uh oh!

Manik2708 commented Dec 6, 2025

Uh oh!

yurishkuro commented Dec 6, 2025

Uh oh!

Manik2708 commented Dec 6, 2025

Uh oh!

yurishkuro commented Dec 6, 2025

Uh oh!

Manik2708 commented Dec 6, 2025

Uh oh!

Manik2708 commented Dec 6, 2025

Uh oh!

yurishkuro Dec 7, 2025

Choose a reason for hiding this comment

Uh oh!

yurishkuro Dec 7, 2025

Choose a reason for hiding this comment

Uh oh!

yurishkuro commented Dec 7, 2025

Uh oh!

Manik2708 commented Dec 7, 2025

Uh oh!

yurishkuro commented Dec 7, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

[storage][cassandra] Make v1 `SpanWriter` reusable for v2 #7699

[storage][cassandra] Make v1 `SpanWriter` reusable for v2 #7699

codecov bot commented Dec 5, 2025 •

edited

Loading