-
-
Notifications
You must be signed in to change notification settings - Fork 36.1k
Ensure that None Roborock maps are updated. #158151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
|
Hey there @allenporter, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
|
@allenporter Will write tests for this later once we are through the big push. For now, I just wanted to make this so I didn't forget it. |
| > IMAGE_CACHE_INTERVAL | ||
| ) | ||
| or self.last_update_state != new_status.state_name | ||
| or ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I worry this will make it run faster than IMAGE_CACHE_INTERVAL when map is None (e.g. if its broken and stuck as None)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah great call it should probably move up with that other if that includes the time interval check
Breaking change
Proposed change
Fixes a bug where the roborock map was not being updated as it ended up in a None state and it was waiting for a cleaning to update.
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: