-
-
Notifications
You must be signed in to change notification settings - Fork 36.1k
Add trigger for vacuum returning to dock #158143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
|
@dmorra12 you need to add the missing label. See the |
Hey @SanderBlom, the labels section isn't showing as editable by me for this PR, otherwise I would add the I had assumed that changing the status from draft -> ready would trigger a re-scan of the template checkboxes but that doesn't seem to be the case |
|
@dmorra12 Unsure. I just created a PR and I think it automatically added the correct label probably based on the PR title or description. You can try to update the description or title of you PR and see if triggers a new check from the bot, if not, you probably have to wait until a maintainers manually adds it. |
|
Looks good to me! Code follows the existing patterns, tests cover everything, and the icon choices make sense. Nice addition. |
|
All looks good, code follows the design patterns set from before, test seems to have covered everything. It's a nice addition and one that should be added. |
Proposed change
Adds a trigger for the vacuum entity for the existing activity state:
VacuumActivity.RETURNINGNote: Triggers for the vacuum entity were introduced in #156870.
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: