fix(cli,exporters,docs): make weasyprint optional and update pdf setup instructions #37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…p instructions - guard pdfexporter with runtime check for missing weasyprint - raise clear runtimeerror when pdf export requested without dependency - silence traceback in click cli, showing only concise error message - add pytest skip logic for pdf export tests when weasyprint not installed - add coverage test for missing weasyprint branch in pdfexporter - update readme and readme-pypi.md with new sections: - 📄 optional pdf export -⚠️ weasyprint setup (linux, macos, windows instructions) breaking change: weasyprint is no longer a hard dependency. users who need pdf export must install with: pip install dns-benchmark-tool[pdf]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
breaking change: weasyprint is no longer a hard dependency. users who need pdf export must install with:
pip install dns-benchmark-tool[pdf]