1st December 2025 - GitProxy Meeting Minutes

[kriswest]

Date

20251201 - 4pm GMT / 11am EST

Meeting info

• Meeting link

• Register for future meetings

Untracked attendees

• Full Name, Affiliation, (optional) GitHub username
• ...

Meeting notices

• FINOS Project leads are responsible for observing the FINOS guidelines for running project meetings. Project maintainers can find additional resources in the FINOS Maintainers Cheatsheet.

• All participants in FINOS project meetings are subject to the LF Antitrust Policy, the FINOS Community Code of Conduct and all other FINOS policies.

• FINOS meetings involve participation by industry competitors, and it is the intention of FINOS and the Linux Foundation to conduct all of its activities in accordance with applicable antitrust and competition laws. It is therefore extremely important that attendees adhere to meeting agendas, and be aware of, and not participate in, any activities that are prohibited under applicable US state, federal or foreign antitrust and competition laws. Please contact legal@finos.org with any questions.

• FINOS project meetings may be recorded for use solely by the FINOS team for administration purposes. In very limited instances, and with explicit approval, recordings may be made more widely available.

Agenda

• Convene & roll call (5mins)
• Review Meeting Notices (see above) and FINOS Antitrust Policy summary slide
• Approve past meeting minutes
  • 17th November 2025 - GitProxy Meeting Minutes #1269
• SSH flow setup and demo
• Vitest PR final check and merge refactor: migrate tests to Vitest + TS #1202
  • See also Failing proxy tests (test cleanup issues) #1294
• Subsequent push error bug - triage and progress Subsequent pushes to the same branch fail: Invalid revision range #1291
• fix: drop dependency on jwk-to-pem by using native crypto #1283
• fix: misleading endpoint status codes and error messages #1293
• feat: Add reject reason #1295
• + any other inflight PRs we need to look at
• Allow users to commit using both corporate and external email addresses #1271
• Review and improve Git proxy getting started and config documentation #1272
• Improve logging in processors/action chain #1281
• Improve endpoint status codes (/src/service/routes) #1285
• Default config for fileDB contains unused properties #1288
• Reveal rejected pushes in the Dashboard and consider an advisory category or output #1292
• Make uiRouteAuth more flexible #1296
• Improve pagination defaults and layout in admin UI #1297
• Support AWS IAM credentials / AWS Credentials providers in the MongoDB connection config #1299
• AOB, Q&A & Adjourn (5mins)

Minutes

• Approval of Past Meeting Minutes
  Last meeting minutes (17th November 2025 - GitProxy Meeting Minutes #1269) presented; no objections or amendments raised.

• Action Items from Last Meeting

  • Follow-up on Dockerised testing and MongoDB integration PR assigned to @coopernetes is ongoing, with @dcoric and @jescalada to resolve merge conflicts with the Vitest migration.
  • Documentation updates have started (@tabathad), including homepage refresh and demo video fixes. Further review and testimonial selection pending.
  • Hybrid cache architecture PR (feat: implement hybrid cache architecture #1246) review is ongoing; @jescalada, @kriswest, @grovesy and @andypols to review, with @RichardUri to notify @grovesy. Security and architectural reviews especially encouraged.
  • Draft notification system design is pending (@06kellyjac); to be prioritised after v2 release.
  • Open issues will be reviewed prior to next release candidate; some issues highlighted for inclusion in v2 scope.

• SSH Flow Setup and Demo

  • @fabiovincenzi presented and demoed the updated SSH agent forwarding implementation.
  • Internal rewrites were required due to limitations in upstream libraries; PR to be published post-meeting.
  • Feedback to add SSH flow setup instructions to the admin UI for discoverability; documentation improvements needed.
  • Compatibility with GitLab to be checked before PR is finalised.
  • Deprecation of proxyUrl in config to be addressed per new architectural requirements.

• Vitest PR Final Check & Related Testing Issues

  • @jescalada led the Vitest migration (refactor: migrate tests to Vitest + TS #1202); all but one review comment resolved.
  • CLI coverage is not currently collected; consensus to skip for now and raise a follow-up issue for future coverage.
  • Approval from @kriswest and @coopernetes pending final checks.
  • Failing proxy tests (Failing proxy tests (test cleanup issues) #1294) are due to improper cleanup/mock behaviour between test files; @jescalada to investigate and resolve.

• Subsequent Push Error Bug

  • Subsequent pushes to the same branch fail: Invalid revision range (Subsequent pushes to the same branch fail: Invalid revision range #1291).
  • @kriswest, @jescalada, and @andypols discussed causes (shallow clone, missing refs, getDiff logic).
  • @kriswest to research correct git usage for resolving refs; @andypols to share workaround.

• PR/Issue Quick Reviews

  • Drop jwk-to-pem Dependency (fix: drop dependency on jwk-to-pem by using native crypto #1283): Test added by @jescalada; waiting for security review and approval from the maintainer’s team.
  • Misleading Endpoint Status Codes/Error Messages (fix: misleading endpoint status codes and error messages #1293): @jescalada is refactoring, tied to the Vitest PR chain.
  • Add Reject Reason (feat: Add reject reason #1295): @andypols implemented requiring reasons for rejections; broad support for this addition.
  • Other In-flight PRs:
    • Both corporate/external emails (Allow users to commit using both corporate and external email addresses #1271): @andypols to contribute changes.
    • Improving getting started/config docs (Review and improve Git proxy getting started and config documentation #1272): @tabathad and @kriswest to continue.
    • Logging improvements (Improve logging in processors/action chain #1281), endpoint status codes (/src/service/routes) (Improve endpoint status codes (/src/service/routes) #1285), FileDB config cleanup (Default config for fileDB contains unused properties #1288), rejected pushes in dashboard (Reveal rejected pushes in the Dashboard and consider an advisory category or output #1292), flexible uiRouteAuth (Make uiRouteAuth more flexible #1296), admin UI pagination/layout (Improve pagination defaults and layout in admin UI #1297), AWS IAM credentials for MongoDB (Support AWS IAM credentials / AWS Credentials providers in the MongoDB connection config #1299): Briefly reviewed, all remain open for contributors. Some are in progress or pending further review.

• AOB and General Discussion

  • Documentation is out of date; @tabathad to provide a critical issues list for v2.
  • Consideration of a doc check for PRs and improving the contribution template.
  • Discussion on improving JSON schema generation for docs; alternatives to be researched.
  • Pagination in the UI, rejected/advisory handling, and attestation improvements discussed as medium-term goals.

Action Items

• @dcoric and @jescalada to coordinate resolving Vitest/TS and dockerised testing PR merge conflicts with @coopernetes.
• @tabathad to finish homepage/testimonial review and suggest a social media strategy; @kriswest to review and confirm testimonial use.
• @tabathad to compile and post a list of documentation gaps/critical updates to existing docs issue.
• @kriswest, @jescalada, @grovesy, @andypols, and interested others to review hybrid cache architecture PR (feat: implement hybrid cache architecture #1246); @RichardUri to notify @grovesy.
• @06kellyjac to prioritise notification system design work post-v2.
• @fabiovincenzi to create SSH agent forwarding PR, check GitLab compatibility, and improve admin UI/doco per feedback.
• @kriswest to review and sign off Vitest PR (refactor: migrate tests to Vitest + TS #1202) when prompted by @jescalada.
• @coopernetes to review Vitest PR (refactor: migrate tests to Vitest + TS #1202) for architectural issues.
• @jescalada to raise an issue for CLI coverage and ensure explanatory comments are added.
• @jescalada to diagnose and fix proxy test cleanup/mocking issues to resolve Failing proxy tests (test cleanup issues) #1294.
• @kriswest to research git usage for resolving branch push errors (Subsequent pushes to the same branch fail: Invalid revision range #1291) and coordinate with @andypols on sharing patch/workaround.
• @jescalada to request review on jwk-to-pem removal PR (fix: drop dependency on jwk-to-pem by using native crypto #1283) once team review complete; @kriswest or another maintainer to approve.
• @andypols to submit PRs for both corporate and external email support (Allow users to commit using both corporate and external email addresses #1271).
• @tabathad and @kriswest to further update getting started/config documentation (Review and improve Git proxy getting started and config documentation #1272).
• @kriswest to update FileDB config to remove unused properties (Default config for fileDB contains unused properties #1288), or improve property handling.
• @kriswest (and/or contributors) to improve admin UI pagination defaults/layout (Improve pagination defaults and layout in admin UI #1297).
• @kriswest to implement/test AWS IAM credentials integration for MongoDB config (Support AWS IAM credentials / AWS Credentials providers in the MongoDB connection config #1299).
• All to review and give feedback on error message, UI improvements, and rejected push/dashboard handling as PRs are raised.
• @tabathad to propose PR template/doc check improvements.
• @kriswest to circulate minutes and action items; all to notify of corrections if needed.

[kriswest]

Feel free to add to the next meeting agenda (@finos/git-proxy-maintainers & @finos/git-proxy-contributors)

[kriswest]

Minutes posted - sorry for the delay!