Restrict developers from overriding blocked pushes

[sam-holmes2]

Is your feature request related to a problem? Please describe.
Currently if a developer receives a blocked push by GitProxy, they can override the block and submit the offending code for review.

Describe the solution you'd like
These override capabilities should be restricted. Instead, a reviewer should be required to attest that the exceptions are not offending and suitable to be open sourced prior to review.

[jescalada]

@sam-holmes2 I'd love to have an example flow to reproduce this bug - I'm aware that rejected PRs can be pushed again without any changes (not sure if by design), but I thought PRs blocked by the push actions don't ever make it to the UI review step. 🤔

[kriswest]

I was under the impression that you can re-push a cancelled review, but a blocked on remains blocked... However, it appears that that is not the case - I believe we reconnect to past actions in checkIfWaitingAuth:

git-proxy/src/proxy/processors/push-action/checkIfWaitingAuth.ts

Line 11 in d4d9239

if (existingAction.authorised) {

Where you can see its only approved reviews (action.authorised == true) that count.

However, if we change that, how would you resolve something that was rejected in review by mistake or because something that is later clarified between the reviewer and contributor changes their mind on the review. The only way would be to add further changes and resubmit (although I imagine in most such cases adding a comment might be warranted).