PLAT-2788: Re-enable Rubocop (#78)

* update renamed cops

* autocorrect frozen_string_literal, indentation, minor styling

* auto-correct RSpec/BeEq

* call super in ApiError

* address Lint/DuplicateMethods

* enable NewCops and auto-correct correctable changes

* run rubocop --auto-gen-config --autocorrect-all

* disable suggested extensions and add rubocop to ci

* Seperate Rubocop into seperate CI job

Author: abdallaharar

.github/workflows/ci.yml

@@ -21,3 +21,19 @@ jobs:
 
       - name: Run tests
         run: bundle exec rake spec
+
+  rubocop:
+    runs-on: ubuntu-latest
+
+    steps:
+      - name: Checkout code
+        uses: actions/checkout@v4
+
+      - name: Set up Ruby
+        uses: ruby/setup-ruby@v1
+        with:
+          ruby-version: .ruby-version
+          bundler-cache: true
+
+      - name: Run RuboCop
+        run: bundle exec rubocop

.rubocop.yml

@@ -1,12 +1,15 @@
-require: rubocop-rspec
+plugins: rubocop-rspec
 
 inherit_from: .rubocop_todo.yml
 
+AllCops:
+    NewCops: enable
+    SuggestExtensions: false
 RSpec/DescribedClass:
   EnforcedStyle: explicit
 Style/StringLiterals:
   Enabled: false
 Style/Documentation:
   Enabled: false
-Metrics/LineLength:
+Layout/LineLength:
   Max: 120

.rubocop_todo.yml

@@ -1,48 +1,42 @@
 # This configuration was generated by
 # `rubocop --auto-gen-config`
-# on 2019-10-01 16:24:59 -0400 using RuboCop version 0.64.0.
+# on 2025-07-18 18:25:48 UTC using RuboCop version 1.78.0.
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new
 # versions of RuboCop, may require this file to be generated again.
 
 # Offense count: 6
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle, IndentationWidth.
-# SupportedStyles: with_first_parameter, with_fixed_indentation
-Layout/AlignParameters:
+# Configuration parameters: EnforcedStyle, AllowedGems, Include.
+# SupportedStyles: Gemfile, gems.rb, gemspec
+# Include: **/*.gemspec, **/Gemfile, **/gems.rb
+Gemspec/DevelopmentDependencies:
   Exclude:
-    - 'lib/marqeta.rb'
+    - 'marqeta.gemspec'
 
 # Offense count: 1
-# Cop supports --auto-correct.
+# This cop supports safe autocorrection (--autocorrect).
 Layout/EmptyLineAfterGuardClause:
   Exclude:
     - 'lib/marqeta/user.rb'
 
 # Offense count: 1
-# Cop supports --auto-correct.
-Layout/LeadingBlankLines:
-  Exclude:
-    - 'marqeta.gemspec'
-
-# Offense count: 20
-# Configuration parameters: CountComments, ExcludedMethods.
-# ExcludedMethods: refine
-Metrics/BlockLength:
-  Max: 442
+# Configuration parameters: AllowedMethods, AllowedPatterns, CountRepeatedAttributes.
+Metrics/AbcSize:
+  Max: 21
 
 # Offense count: 1
-# Configuration parameters: CountComments.
+# Configuration parameters: CountComments, CountAsOne.
 Metrics/ClassLength:
   Max: 110
 
-# Offense count: 1
-# Configuration parameters: CountComments, ExcludedMethods.
+# Offense count: 2
+# Configuration parameters: CountComments, CountAsOne, AllowedMethods, AllowedPatterns.
 Metrics/MethodLength:
   Max: 15
 
 # Offense count: 1
+# This cop supports unsafe autocorrection (--autocorrect-all).
 # Configuration parameters: EnforcedStyleForLeadingUnderscores.
 # SupportedStylesForLeadingUnderscores: disallowed, required, optional
 Naming/MemoizedInstanceVariableName:
@@ -51,64 +45,76 @@ Naming/MemoizedInstanceVariableName:
 
 # Offense count: 2
 # Configuration parameters: MinNameLength, AllowNamesEndingInNumbers, AllowedNames, ForbiddenNames.
-# AllowedNames: io, id, to, by, on, in, at, ip, db
-Naming/UncommunicativeMethodParamName:
+# AllowedNames: as, at, by, cc, db, id, if, in, io, ip, of, on, os, pp, to
+Naming/MethodParameterName:
   Exclude:
     - 'lib/marqeta/api_caller.rb'
 
 # Offense count: 11
 RSpec/AnyInstance:
   Exclude:
-    - 'spec/marqeta/api_caller_spec.rb'
     - 'spec/marqeta/api_object_spec.rb'
     - 'spec/marqeta/card_spec.rb'
     - 'spec/marqeta/transaction_spec.rb'
 
 # Offense count: 1
-# Configuration parameters: Prefixes.
+# Configuration parameters: Prefixes, AllowedPatterns.
 # Prefixes: when, with, without
 RSpec/ContextWording:
   Exclude:
     - 'spec/marqeta/api_caller_spec.rb'
 
-# Offense count: 4
-# Configuration parameters: Max.
+# Offense count: 5
+# Configuration parameters: CountAsOne.
 RSpec/ExampleLength:
-  Exclude:
-    - 'spec/marqeta/api_object_spec.rb'
-    - 'spec/marqeta/transaction_spec.rb'
-    - 'spec/marqeta/user_spec.rb'
+  Max: 11
 
 # Offense count: 1
-# Cop supports --auto-correct.
+# This cop supports safe autocorrection (--autocorrect).
 # Configuration parameters: EnforcedStyle.
 # SupportedStyles: implicit, each, example
 RSpec/HookArgument:
   Exclude:
     - 'spec/marqeta/transaction_spec.rb'
 
-# Offense count: 32
+# Offense count: 12
+# Configuration parameters: Max, AllowedIdentifiers, AllowedPatterns.
+RSpec/IndexedLet:
+  Exclude:
+    - 'spec/marqeta/api_object_spec.rb'
+
+# Offense count: 35
 # Configuration parameters: .
 # SupportedStyles: have_received, receive
 RSpec/MessageSpies:
   EnforcedStyle: receive
 
-# Offense count: 8
-# Configuration parameters: AggregateFailuresByDefault.
+# Offense count: 9
 RSpec/MultipleExpectations:
   Max: 8
 
+# Offense count: 55
+# Configuration parameters: AllowSubject.
+RSpec/MultipleMemoizedHelpers:
+  Max: 13
+
 # Offense count: 36
+# Configuration parameters: AllowedGroups.
 RSpec/NestedGroups:
   Max: 4
 
+# Offense count: 1
+RSpec/StubbedMock:
+  Exclude:
+    - 'spec/marqeta/card_spec.rb'
+
 # Offense count: 1
 RSpec/SubjectStub:
   Exclude:
     - 'spec/marqeta/api_object_spec.rb'
 
 # Offense count: 1
-# Cop supports --auto-correct.
+# This cop supports safe autocorrection (--autocorrect).
 Style/ExpandPathArguments:
   Exclude:
     - 'marqeta.gemspec'

Gemfile

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 source "https://rubygems.org"
 
 git_source(:github) { |repo_name| "https://github.com/#{repo_name}" }

Rakefile

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "bundler/gem_tasks"
 require "rspec/core/rake_task"
 require "rubocop/rake_task"

bin/console

@@ -1,4 +1,5 @@
 #!/usr/bin/env ruby
+# frozen_string_literal: true
 
 require "bundler/setup"
 require "marqeta"

lib/marqeta.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'marqeta/card'
 require 'marqeta/client_access'
 require 'marqeta/gateway_response_codes'
@@ -11,13 +13,13 @@
 module Marqeta
   class Configuration
     attr_accessor :username,
-      :password,
-      :base_url,
-      :dashboard_base_url,
-      :logger,
-      :webhook_endpoint,
-      :webhook_username,
-      :webhook_password
+                  :password,
+                  :base_url,
+                  :dashboard_base_url,
+                  :logger,
+                  :webhook_endpoint,
+                  :webhook_username,
+                  :webhook_password
   end
 
   class << self
@@ -27,7 +29,7 @@ def configure
     end
 
     def configuration
-      @_configuration ||= Configuration.new
+      @configuration ||= Configuration.new
     end
   end
 end

lib/marqeta/api_caller.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'json'
 require 'faraday'
 require 'marqeta/errors'
@@ -39,17 +41,14 @@ def put(payload)
     private
 
     attr_reader :endpoint
-    attr_reader :connection
 
     def perform_action
-      begin
-        response = yield
-        handle_successful_response response
-      rescue Faraday::ClientError => e
-        handle_exception_with_response(e)
-      rescue *HttpError::ERROR_LIST => e
-        handle_http_error e
-      end
+      response = yield
+      handle_successful_response response
+    rescue Faraday::ClientError => e
+      handle_exception_with_response(e)
+    rescue *HttpError::ERROR_LIST => e
+      handle_http_error e
     end
 
     def connection

lib/marqeta/api_object.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'marqeta/api_caller'
 require 'time'
 
@@ -45,7 +47,7 @@ def self.object_list(klass, endpoint)
       results.map { |data_hash| klass.new(data_hash) }
     end
 
-    def method_missing(method_name, *args, &block)
+    def method_missing(method_name, *args, &)
       if respond_to_missing?(method_name)
         attribute_value(method_name)
       else
@@ -70,9 +72,8 @@ def accessible_time_attributes
     end
 
     def symbolized_attributes_hash
-      new_array = []
-      attributes_hash.each{ |k, v| new_array << [k.to_sym, v] }
-      Hash[new_array]
+      new_array = attributes_hash.map { |k, v| [k.to_sym, v] }
+      new_array.to_h
     end
 
     def attribute_value(attribute)

lib/marqeta/card.rb

@@ -1,10 +1,12 @@
+# frozen_string_literal: true
+
 require 'marqeta/api_object'
 require 'marqeta/client_access'
 require 'marqeta/card_transition'
 
 module Marqeta
   class Card < ApiObject
-    ACTIVE_STATE = 'ACTIVE'.freeze
+    ACTIVE_STATE = 'ACTIVE'
 
     def self.endpoint
       'cards'