fix: support stacked modals on iOS #54781
Open
+75
−5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
We have had two bugs related to iOS modals. The first is when dismissing and presenting different modals in parallel, when we do this we end up in a weird state where the second modal is not presented and seems to block the UI from receiving touches. The second bug is when trying to present a second modal while a first one is presented.
This PR introduces some extra logic to ensure we always present the latest modal in the active view. This ensures we never have the parallel bug plus allows us to present multiple modals mimicking the current behavior from Android as well.
notworkingdemo.mp4
working-success.mp4
The new behavior also matches exactly how Android already works:
rn-tester-android.mov