add debug statements to debugger shell launching path #54929
Closed
+27
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
vzaidman
force-pushed
the
export-D88955169
branch
from
7ae5217 to
86aec4f
Compare
vzaidman
added a commit
to vzaidman/react-native
that referenced
this pull request
Dec 19, 2025
Summary: There's a bug in Node.JS: nodejs/node#51018 where spawning a process on Windows with detached mode and unref will not actually inherit stdio. You need to manually pipe these to get to see stdout and stderr. It works well on MacOS though. Changelog: [Internal] Differential Revision: D88955169
vzaidman
added a commit
to vzaidman/react-native
that referenced
this pull request
Dec 19, 2025
Summary: There's a bug in Node.JS: nodejs/node#51018 where spawning a process on Windows with detached mode and unref will not actually inherit stdio. You need to manually pipe these to get to see stdout and stderr. It works well on MacOS though. Changelog: [Internal] Reviewed By: huntie Differential Revision: D88955169
vzaidman
force-pushed
the
export-D88955169
branch
2 times, most recently
from
7ee24f0 to
2f9c6a7
Compare
vzaidman
added a commit
to vzaidman/react-native
that referenced
this pull request
Dec 19, 2025
Summary: There's a bug in Node.JS: nodejs/node#51018 where spawning a process on Windows with detached mode and unref will not actually inherit stdio. You need to manually pipe these to get to see stdout and stderr. It works well on MacOS though. Changelog: [Internal] Reviewed By: huntie Differential Revision: D88955169
Summary: There's a bug in Node.JS: nodejs/node#51018 where spawning a process on Windows with detached mode and unref will not actually inherit stdio. You need to manually pipe these to get to see stdout and stderr. It works well on MacOS though. Changelog: [Internal] Reviewed By: huntie Differential Revision: D88955169
vzaidman
force-pushed
the
export-D88955169
branch
from
2f9c6a7 to
2c4dafc
Compare
|
This pull request has been merged in c00173f. |
Collaborator
|
This pull request was successfully merged by @vzaidman in c00173f When will my fix make it into a release? | How to file a pick request? |
Contributor
|
This pull request has been reverted by 17cba6e. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
There's a bug in Node.JS: nodejs/node#51018 where spawning a process on Windows with detached mode and unref will not actually inherit stdio. You need to manually pipe these to get to see stdout and stderr. It works well on MacOS though.
Changelog: [Internal]
Differential Revision: D88955169