-
Notifications
You must be signed in to change notification settings - Fork 456
feat: replace docker compose with dotnet aspire #223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR migrates the local development environment from Docker Compose to .NET Aspire, introducing a new Fitnet.AppHost project for orchestration. The change aims to improve developer experience through strong typing, built-in observability, and simplified connection string management.
Key Changes:
- Added Fitnet.AppHost project with .NET Aspire 9.0 for orchestrating PostgreSQL and the Fitnet application
- Removed Docker Compose configuration (docker-compose.yml, Dockerfile, .dockerignore)
- Updated SonarAnalyzer.CSharp package to version 10.15.0.120848 across all test projects
- Modified application URL ports in launchSettings.json to avoid conflicts
Reviewed changes
Copilot reviewed 21 out of 21 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| README.adoc | Added .NET Aspire to the technology stack list |
| Chapter-1-initial-architecture/Src/docker-compose.yml | Removed Docker Compose configuration in favor of Aspire |
| Chapter-1-initial-architecture/Src/Dockerfile | Removed Dockerfile as containerization is now handled by Aspire |
| Chapter-1-initial-architecture/Src/Fitnet/.dockerignore | Removed Docker ignore file (no longer needed) |
| Chapter-1-initial-architecture/Src/Fitnet/Properties/launchSettings.json | Updated ports to avoid conflicts (7097→7098, 5013→5014) |
| Chapter-1-initial-architecture/Src/Fitnet/Program.cs | Removed module registration comment |
| Chapter-1-initial-architecture/Src/Fitnet/Fitnet.csproj | Removed docker-compose.yml and Dockerfile content links |
| Chapter-1-initial-architecture/Src/Fitnet.AppHost/* | Added new Aspire AppHost project with PostgreSQL and Fitnet application orchestration |
| Chapter-1-initial-architecture/Src/Fitnet.slnx | Added Fitnet.AppHost project and updated project type attributes |
| Chapter-1-initial-architecture/Src/.UnitTests/.csproj | Updated SonarAnalyzer.CSharp to version 10.15.0.120848 |
| Chapter-1-initial-architecture/Src/.IntegrationTests/.csproj | Updated SonarAnalyzer.CSharp to version 10.15.0.120848 |
| Chapter-1-initial-architecture/Src/.ArchitectureTests/.csproj | Updated SonarAnalyzer.CSharp to version 10.15.0.120848 |
| Chapter-1-initial-architecture/Src/Fitnet//Migrations/.cs | Added blank lines after namespace declarations for consistent formatting |
| Chapter-1-initial-architecture/README.adoc | Updated local development instructions for Aspire |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Chapter-1-initial-architecture/Src/Fitnet.AppHost/Fitnet.AppHost.csproj
Outdated
Show resolved
Hide resolved
Co-authored-by: Copilot <[email protected]>
…st.csproj Co-authored-by: Copilot <[email protected]>
Changes:
Rationale: