Merge pull request #20978 from boqishan/main

refactor: use strings.Cut to simplify code

Author: ahrtr

tools/benchmark/cmd/util.go

@@ -37,18 +37,16 @@ func getUsernamePassword(usernameFlag string) (string, string, error) {
 	if globalUserName != "" && globalPassword != "" {
 		return globalUserName, globalPassword, nil
 	}
-	colon := strings.Index(usernameFlag, ":")
-	if colon == -1 {
+	var ok bool
+	globalUserName, globalPassword, ok = strings.Cut(usernameFlag, ":")
+	if !ok {
 		// Prompt for the password.
 		password, err := speakeasy.Ask("Password: ")
 		if err != nil {
 			return "", "", err
 		}
 		globalUserName = usernameFlag
 		globalPassword = password
-	} else {
-		globalUserName = usernameFlag[:colon]
-		globalPassword = usernameFlag[colon+1:]
 	}
 	return globalUserName, globalPassword, nil
 }