-
Notifications
You must be signed in to change notification settings - Fork 7.8k
Open
Labels
Type: Feature requestFeature request for Arduino ESP32Feature request for Arduino ESP32
Description
Related area
WebServer
Hardware specification
Doesn't matter
Is your feature request related to a problem?
In the WebServer class, void WebServer::sendContent_P(PGM_P content, size_t size) is not virtual, i.e.. not overridable. However, its implementation uses _currentClient. That makes it impossible to implement a derived class, e.g. to implement a TLS-protected SecureWebServer. For that, I'd have to use a SecureClient member.
At least that applies when I want to do "proper polymorphism", i.e. access my potential SecureWebServer via a WebServer pointer.
Describe the solution you'd like
- Make all methods using
_currentClientvirtual - Alternatively, make use of the
client()virtual method consistently?
Describe alternatives you've considered
No response
Additional context
No response
I have checked existing list of Feature requests and the Contribution Guide
- I confirm I have checked existing list of Feature requests and Contribution Guide.
Metadata
Metadata
Assignees
Labels
Type: Feature requestFeature request for Arduino ESP32Feature request for Arduino ESP32