ci: Fix the workflow for publishing release images to Docker Hub #3650
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using GITHUB_TOKEN to push new release tags to the GitHub repo prevents triggering of other GHA actions that watch for the 'release' event. Using a PAT instead works around this limitation.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3650 +/- ##
=======================================
Coverage 87.91% 87.91%
=======================================
Files 22 22
Lines 1820 1820
Branches 458 460 +2
=======================================
Hits 1600 1600
Misses 218 218
Partials 2 2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had made a few mistakes in the
sync_service_dockerhub_image.ymlworkflow when I migrated the publishing of Docker Hub images from Buildkite to GHA:github.event.pull_request.head.shawith the correct oneIn this PR:
changesets_release.yml, in the step where to pushes new GIt tag to GitHub. This should make the image building workflow trigerable by releases created in another workflow.