Skip to content

Commit f63cc7c

Browse files
committed
label manager: Remove data directory and document how to add label files
Users should now mount label CSV files at runtime using volume mounts (Docker) or init containers with cloud storage (Kubernetes). Changes - Removed COPY data/ line from both Dockerfiles - The /data directory is still created (mkdir -p /app /data) but empty - Updated .gitignore to ignore entire data/ directory - Removed data/** trigger from docker-publish workflow - Added comprehensive docs/label_manager.md with: * Docker volume mount examples * Kubernetes init container pattern (recommended for large files) * ConfigMap examples (for small files <1MB) * PersistentVolume examples (for shared access) * Performance considerations and troubleshooting
1 parent 54d0026 commit f63cc7c

File tree

5 files changed

+470
-7
lines changed

5 files changed

+470
-7
lines changed

.github/workflows/docker-publish.yml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@ on:
77
paths:
88
- 'src/**'
99
- 'apps/**'
10-
- 'data/**'
1110
- 'Dockerfile*'
1211
- 'pyproject.toml'
1312
- '.github/workflows/docker-publish.yml'

.gitignore

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -54,10 +54,8 @@ htmlcov/
5454
uv.lock
5555

5656
# Data directories (local development)
57-
data/*.csv
58-
data/*.parquet
59-
data/*.db
60-
data/*.lmdb
57+
# Large datasets should be downloaded on-demand or mounted via ConfigMaps
58+
data/
6159

6260
# Build artifacts
6361
*.tar.gz

Dockerfile

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -68,9 +68,11 @@ COPY --from=builder /usr/local/bin/uv /usr/local/bin/uv
6868
# Copy application code
6969
COPY --chown=amp:amp src/ ./src/
7070
COPY --chown=amp:amp apps/ ./apps/
71-
COPY --chown=amp:amp data/ ./data/
7271
COPY --chown=amp:amp pyproject.toml README.md ./
7372

73+
# Note: /data directory is created but empty by default
74+
# Mount data files at runtime using Kubernetes ConfigMaps or volumes
75+
7476
# Install the amp package in the system Python (NOT editable for Docker)
7577
RUN uv pip install --system --no-cache .
7678

Dockerfile.snowflake

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -63,9 +63,11 @@ COPY --from=builder /usr/local/bin/uv /usr/local/bin/uv
6363
# Copy application code
6464
COPY --chown=amp:amp src/ ./src/
6565
COPY --chown=amp:amp apps/ ./apps/
66-
COPY --chown=amp:amp data/ ./data/
6766
COPY --chown=amp:amp pyproject.toml README.md ./
6867

68+
# Note: /data directory is created but empty by default
69+
# Mount data files at runtime using Kubernetes ConfigMaps or volumes
70+
6971
# Install the amp package (system install for Docker)
7072
RUN uv pip install --system --no-cache --no-deps .
7173

0 commit comments

Comments
 (0)