Skip to content

added existing group pr number in logs #13594

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
alhss merged 7 commits into from
Dec 5, 2025
Merged

added existing group pr number in logs #13594

alhss merged 7 commits into from
Dec 5, 2025
+15 −2

Conversation

@alhss
Copy link
Contributor

@alhss alhss commented Nov 19, 2025 •
edited
Loading

related : #13101

What are you trying to accomplish?

i added a pr number of existing group pull request to logs so users can easily refer to existing ones. this is a continuation of the work i did for individual pull requests.

Anything you want to highlight for special attention from reviewers?

How will you know you've accomplished your goal?

Checklist

  • I have run the complete test suite to ensure all tests and linters pass.
  • I have thoroughly tested my code changes to ensure they work as expected, including adding additional tests for new functionality.
  • I have written clear and descriptive commit messages.
  • I have provided a detailed description of the changes in the pull request, including the problem it addresses, how it fixes the problem, and any relevant details about the implementation.
  • I have ensured that the code is well-documented and easy to understand.

@alhss alhss marked this pull request as ready for review November 19, 2025 17:24
@alhss alhss requested a review from a team as a code owner November 19, 2025 17:24
@alhss alhss changed the title add display of existing group pr number in logs added existing group pr number in logs Nov 19, 2025
@alhss alhss force-pushed the alhss/display-group-pr-number branch from 786cd2c to da616d6 Compare December 1, 2025 16:35
jakecoffman
jakecoffman previously approved these changes Dec 2, 2025
View reviewed changes
@alhss alhss requested a review from jakecoffman December 2, 2025 15:52
yeikel
yeikel reviewed Dec 2, 2025
View reviewed changes
yeikel
yeikel reviewed Dec 3, 2025
View reviewed changes
Copy link
Contributor

@yeikel yeikel left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Thanks for applying the feedback

@alhss alhss force-pushed the alhss/display-group-pr-number branch from a37fb61 to ae0b96a Compare December 5, 2025 21:11
@alhss alhss enabled auto-merge December 5, 2025 21:13
@alhss alhss merged commit c093035 into main Dec 5, 2025
165 checks passed
@alhss alhss deleted the alhss/display-group-pr-number branch December 5, 2025 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rickreyhsig rickreyhsig rickreyhsig approved these changes

@jakecoffman jakecoffman Awaiting requested review from jakecoffman

+1 more reviewer

@yeikel yeikel yeikel left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@alhss @jakecoffman @rickreyhsig @yeikel