Merge pull request #13689 from caugner/npm_and_yarn/engines_field_for_package_manager_with_caret_and_major_version

fix(npm): parse caret constraint with major-only version

Author: markhallen

npm_and_yarn/lib/dependabot/npm_and_yarn/constraint_helper.rb

@@ -261,9 +261,16 @@ def self.to_ruby_constraint_with_version(constraint, dependabot_versions = [])
 
           full_version = Regexp.last_match(1)
 
-          # Normalize version: if full_version does not have patch version, add ".0"
+          # Normalize version: ensure it has major.minor.patch format
           version_parts = T.must(full_version).split(".")
-          full_version = "#{full_version}.0" if version_parts.length == 2
+          full_version = case version_parts.length
+                         when 1
+                           "#{full_version}.0.0" # major only -> major.0.0
+                         when 2
+                           "#{full_version}.0"   # major.minor -> major.minor.0
+                         else
+                           full_version          # already major.minor.patch
+                         end
 
           _, major, minor = version_components(full_version)
           return nil if major.nil?

npm_and_yarn/spec/dependabot/npm_and_yarn/package_manager_helper_spec.rb

@@ -141,6 +141,16 @@
       end
     end
 
+    context "with engines field for package manager with '^' constraint and missing minor/patch version" do
+      let(:lockfiles) { {} }
+      let(:package_json) { { "engines" => { "npm" => "^10" } } }
+
+      it "returns a NpmPackageManager instance from engines field" do
+        expect(helper.package_manager).to be_a(Dependabot::NpmAndYarn::NpmPackageManager)
+        expect(helper.package_manager.detected_version).to eq("10")
+      end
+    end
+
     context "with engines field for npm >=11.0.0" do
       let(:lockfiles) { {} }
       let(:package_json) { { "engines" => { "npm" => ">=11.0.0" } } }