Add the test abstraction so that we can design delta integration tests run agaist both locally OSS UC server and external OSS UC server #5628
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Moved UnityCatalogSupport.scala and UnityCatalogSupportSuite.scala to com.sparkuctest package - Updated package declarations from org.apache.spark.sql.delta to com.sparkuctest - All 4 tests pass successfully with Spark 4.0
…, and dependency management
…, and dependency management
…y null checks, use checkAnswer
…y null checks, use checkAnswer; Remove unused import
- Replace Scala UnityCatalogSupport trait with Java abstract class - Replace Scala UnityCatalogSupportSuite with Java JUnit tests - Update build.sbt for Java test support - Remove ScalaTest dependency, use JUnit exclusively - Add Log4j logging instead of System.out.println - Maintain all original test functionality
- Add spark.sql.extensions for DeltaSparkSessionExtension - Add spark.sql.catalog.spark_catalog for DeltaCatalog - Fixes test failures requiring Delta catalog configuration
Address PR comment: use io package instead of com package for test utilities
…s run agaist both locally OSS UC server and external OSS UC server Signed-off-by: openinx <[email protected]>
Signed-off-by: openinx <[email protected]>
Signed-off-by: openinx <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which Delta project/connector is this regarding?
Description
Related issue is: #5624
How was this patch tested?
If we want to do the locally test, which means we set up the local OSS uc server for the testing purpose, then we use this command to run:
./build/sbt -DsparkVersion=3.5.7 "testOnly io.sparkuctest.UCManagedTableDMLTest"If we want to run the same tests against the external UC server, then we can use this command:
In summary, with this abstracted
UnityCatalogExtension, we provided two extension implementations:LocalUnityCatalogExtension, which means run all the tests locally.RemoteUnityCatalogExtension, which means run the same tests remotelly.And the good point is: for the new tests developers, they never need to perceive the underlying setup, all they need is extending the
UnityCatalogTestBase, and write the normal test codes.Does this PR introduce any user-facing changes?
No.