Skip to content

Commit b362a91

Browse files
committed
done
1 parent e1fe755 commit b362a91

File tree

7 files changed

+12
-12
lines changed

7 files changed

+12
-12
lines changed

kernel/kernel-api/src/main/java/io/delta/kernel/internal/tablefeatures/TableFeatures.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -83,7 +83,7 @@ public boolean hasKernelWriteSupport(Metadata metadata) {
8383
}
8484

8585
public static final TableFeature CATALOG_MANAGED_RW_FEATURE =
86-
new CatalogManagedFeatureBase("catalogOwned-preview");
86+
new CatalogManagedFeatureBase("catalogManaged");
8787

8888
private static class CatalogManagedFeatureBase extends TableFeature.ReaderWriterFeature {
8989
CatalogManagedFeatureBase(String featureName) {

kernel/kernel-api/src/test/scala/io/delta/kernel/internal/icebergcompat/IcebergWriterCompatV1MetadataValidatorAndUpdaterSuite.scala

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -271,7 +271,7 @@ class IcebergWriterCompatV1MetadataValidatorAndUpdaterSuite
271271
"typeWidening",
272272
"typeWidening-preview",
273273
"timestampNtz",
274-
"catalogOwned-preview")
274+
"catalogManaged")
275275
val protocol = new Protocol(3, 7, readerFeatures.asJava, writerFeatures.asJava)
276276
val metadata = getCompatEnabledMetadata(cmTestSchema())
277277
validateAndUpdateIcebergWriterCompatV1Metadata(true, metadata, protocol)

kernel/kernel-api/src/test/scala/io/delta/kernel/internal/icebergcompat/IcebergWriterCompatV3MetadataValidatorAndUpdaterSuite.scala

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -385,7 +385,7 @@ class IcebergWriterCompatV3MetadataValidatorAndUpdaterSuite
385385
"variantShredding-preview",
386386
"icebergCompatV2",
387387
"icebergWriterCompatV1",
388-
"catalogOwned-preview")
388+
"catalogManaged")
389389
val protocol = new Protocol(3, 7, readerFeatures.asJava, writerFeatures.asJava)
390390
val metadata = getCompatEnabledMetadata(cmTestSchema())
391391
validateAndUpdateIcebergWriterCompatV3Metadata(true, metadata, protocol)

kernel/kernel-api/src/test/scala/io/delta/kernel/internal/tablefeatures/TableFeaturesSuite.scala

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ class TableFeaturesSuite extends AnyFunSuite {
4040
// Tests for [[TableFeature]] implementations //
4141
/////////////////////////////////////////////////////////////////////////////////////////////////
4242
val readerWriterFeatures = Seq(
43-
"catalogOwned-preview",
43+
"catalogManaged",
4444
"columnMapping",
4545
"deletionVectors",
4646
"timestampNtz",
@@ -201,7 +201,7 @@ class TableFeaturesSuite extends AnyFunSuite {
201201
"domainMetadata",
202202
"vacuumProtocolCheck",
203203
"clustering",
204-
"catalogOwned-preview",
204+
"catalogManaged",
205205
"allowColumnDefaults").foreach {
206206
feature =>
207207
test(s"doesn't support auto enable by metadata: $feature") {
@@ -234,7 +234,7 @@ class TableFeaturesSuite extends AnyFunSuite {
234234
.collect(toList()).asScala
235235

236236
val expected = Seq(
237-
"catalogOwned-preview",
237+
"catalogManaged",
238238
"columnMapping",
239239
"v2Checkpoint",
240240
"variantType",
@@ -258,7 +258,7 @@ class TableFeaturesSuite extends AnyFunSuite {
258258
// are writable because the metadata has not been set the info that
259259
// these features are enabled
260260
val expected = Seq(
261-
"catalogOwned-preview",
261+
"catalogManaged",
262262
"columnMapping",
263263
"allowColumnDefaults",
264264
"v2Checkpoint",
@@ -323,7 +323,7 @@ class TableFeaturesSuite extends AnyFunSuite {
323323

324324
// Reads: Supported table features represented as readerFeatures in the protocol
325325
Seq(
326-
"catalogOwned-preview",
326+
"catalogManaged",
327327
"variantType",
328328
"variantType-preview",
329329
"variantShredding-preview",
@@ -380,7 +380,7 @@ class TableFeaturesSuite extends AnyFunSuite {
380380

381381
checkWriteSupported(
382382
"validateKernelCanWriteToTable: protocol 7 with catalogManaged",
383-
new Protocol(3, 7, singleton("catalogOwned-preview"), singleton("catalogOwned-preview")),
383+
new Protocol(3, 7, singleton("catalogManaged"), singleton("catalogManaged")),
384384
testMetadata())
385385

386386
checkWriteUnsupported(
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
11
{"commitInfo":{"inCommitTimestamp":1712091396253,"timestamp":1712091396253,"operation":"WRITE","operationParameters":{"mode":"ErrorIfExists","partitionBy":"[]"},"isolationLevel":"Serializable","isBlindAppend":true,"operationMetrics":{"numFiles":"1","numOutputRows":"3","numOutputBytes":"996"},"engineInfo":"Apache-Spark/3.5.1 Delta-Lake/3.1.0","txnId":"5df7dc20-b980-4207-a5fd-b69cb4541b2e"}}
22
{"metaData":{"id":"2a1e618f-d92a-4c94-bb06-a2808f8b39f3","format":{"provider":"parquet","options":{}},"schemaString":"{\"type\":\"struct\",\"fields\":[{\"name\":\"letter\",\"type\":\"string\",\"nullable\":true,\"metadata\":{}},{\"name\":\"number\",\"type\":\"long\",\"nullable\":true,\"metadata\":{}},{\"name\":\"a_float\",\"type\":\"double\",\"nullable\":true,\"metadata\":{}}]}","partitionColumns":[],"configuration":{"delta.enableInCommitTimestamps":"true","catalogManaged.unityCatalog.tableId":"12345678-1234-1234-1234-123456789abc"},"createdTime":1712091393302}}
3-
{"protocol":{"minReaderVersion":3,"minWriterVersion":7,"readerFeatures":["catalogOwned-preview"],"writerFeatures":["catalogOwned-preview","inCommitTimestamp"]}}
3+
{"protocol":{"minReaderVersion":3,"minWriterVersion":7,"readerFeatures":["catalogManaged"],"writerFeatures":["catalogManaged","inCommitTimestamp"]}}
44
{"add":{"path":"part-00000-c9f44819-b06d-45dd-b33d-ae9aa1b96909-c000.snappy.parquet","partitionValues":{},"size":996,"modificationTime":1712091396057,"dataChange":true,"stats":"{\"numRecords\":3,\"minValues\":{\"letter\":\"a\",\"number\":1,\"a_float\":1.1},\"maxValues\":{\"letter\":\"c\",\"number\":3,\"a_float\":3.3},\"nullCount\":{\"letter\":0,\"number\":0,\"a_float\":0}}"}}
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,3 @@
11
{"commitInfo":{"inCommitTimestamp":1749830855993,"timestamp":1749830855992,"operation":"CREATE TABLE","operationParameters":{"partitionBy":"[\"part1\"]","clusterBy":"[]","description":null,"isManaged":"false","properties":"{}"},"isolationLevel":"Serializable","isBlindAppend":true,"operationMetrics":{},"engineInfo":"Apache-Spark/4.0.0 Delta-Lake/4.0.0","txnId":"d108f896-9662-4eda-b4de-444a99850aa8"}}
22
{"metaData":{"id":"64dcd182-b3b4-4ee0-88e0-63c159a4121c","format":{"provider":"parquet","options":{}},"schemaString":"{\"type\":\"struct\",\"fields\":[{\"name\":\"part1\",\"type\":\"integer\",\"nullable\":true,\"metadata\":{}},{\"name\":\"col1\",\"type\":\"integer\",\"nullable\":true,\"metadata\":{}}]}","partitionColumns":["part1"],"configuration":{"delta.enableInCommitTimestamps":"true"},"createdTime":1749830855646}}
3-
{"protocol":{"minReaderVersion":3,"minWriterVersion":7,"readerFeatures":["catalogOwned-preview"],"writerFeatures":["catalogOwned-preview","inCommitTimestamp","invariants","appendOnly"]}}
3+
{"protocol":{"minReaderVersion":3,"minWriterVersion":7,"readerFeatures":["catalogManaged"],"writerFeatures":["catalogManaged","inCommitTimestamp","invariants","appendOnly"]}}

kernel/kernel-defaults/src/test/resources/catalog-owned-preview/info.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ FROM (
4545
)
4646
""")
4747

48-
# Then, add `"readerFeatures":["catalogOwned-preview"]` to the _delta_log/001.json protocol
48+
# Then, add `"readerFeatures":["catalogManaged"]` to the _delta_log/001.json protocol
4949
# Then, for commits version $v in [1, 2] move _delta_log/$v.json into
5050
# _delta_log/_staged_commits/$v.$uuid.json, where $uuid is taken from the commitInfo.txnId in
5151
# $v.json

0 commit comments

Comments
 (0)