Issue running on Windows

[julian-hoch]

Hi, rg runs fine on my Linux machine, but on my Windows machine I run into an issue. For some reason, the command seems to break after the first " (quotation) mark, and I get this error:

-*- mode: rg; default-directory: "c:/Temp/" -*-
rg started at Mon Nov 18 15:10:24

"c:/ProgramData/chocolatey/bin/rg.exe" --color=always --colors=match:fg:red --colors=path:fg:magenta --colors=line:fg:green --colors=column:none -n --column --heading --no-config --fixed-strings -e "Padding" .

warning: extra args ignored after '-e'

rg: ripgrep requires at least one pattern to execute a search

rg exited abnormally with code 2 at Mon Nov 18 15:10:25

If I run this in the command line (without the quotation mark around the program binary) that works fine. It seems it stops parsing the command after the " after -e. Any ideas?

[dajva]

Sorry, I don't know Windows and no official support for it I am afraid. Do you know where the quotation mark comes from? shell-quote-argument perhaps? If it's not that you may get away with customizing rg-executable but you would probably have to debug a bit yourself.

I think there are some windows users of this package so seems odd that such an breaking issue would have been unnoticed.

[julian-hoch]

Indeed you are on the right track!
The following works:

(cl-letf (((symbol-function 'shell-quote-argument) (lambda (x &optional y) x)))
(rg "Padding" "*" "C:/Temp" ))

So potentially I need to wrap all my calls to rg with this. I will try that.

[julian-hoch]

Not sure if this is the best way, but I fixed it like this for me:

      (when *win-laptop*
        (defun jh/rg-fixed (old-fn QUERY FILES DIR)
          (cl-letf (((symbol-function 'shell-quote-argument) (lambda (x &optional y) x)))
            (funcall old-fn QUERY FILES DIR)))

        (advice-add #'rg :around #'jh/rg-fixed))

[joca-bt]

It works fine on Windows for me. I'm using the official msvc build (ripgrep-<version>-x86_64-pc-windows-msvc.zip). Just extracted the rg.exe into the bin/ directory of the Emacs installation directory.