A number of refactorings and fixes: yield to block in snippet helper, ensure Request context is available, require necessary libs, etc

Author: toastercup

cortex-snippets-client-ruby.gemspec

@@ -2,6 +2,8 @@
 lib = File.expand_path('../lib', __FILE__)
 $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 require 'cortex/snippets/version'
+require 'cortex-client'
+require 'connection_pool'
 
 Gem::Specification.new do |spec|
   spec.name          = 'cortex-snippets-client-ruby'
@@ -18,7 +20,7 @@ Gem::Specification.new do |spec|
   spec.executables   = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }
   spec.require_paths = ['lib']
 
-  spec.add_dependency 'cortex-client', '~> 0.4.3'
+  spec.add_dependency 'cortex-client', '~> 0.4.5'
   spec.add_dependency 'connection_pool', '~> 2.2.0'
 
   spec.add_development_dependency 'bundler', '~> 1.10'

lib/cortex/snippets/client.rb

@@ -10,10 +10,10 @@ def cortex_client
           end
         end
 
-        def current_webpage
+        def current_webpage(request)
           if defined?(Rails)
-            Rails.cache.fetch("webpages/#{request_url}", expires_in: 30.minutes) do
-              cortex_client.webpages.get_feed(request_url)
+            Rails.cache.fetch("webpages/#{request_url(request)}", expires_in: 30.minutes) do
+              cortex_client.webpages.get_feed(request_url(request))
             end
           else
             raise 'Your Web framework is not supported. Supported frameworks: Rails'
@@ -22,8 +22,8 @@ def current_webpage
 
         private
 
-        def request_url
-          # TODO: Should be turbo-easy to grab request URL from Rack, but this is fine for now
+        def request_url(request)
+          # TODO: Should be grabbing request URL in a framework-agnostic manner, but this is fine for now
           request.original_url
         end
       end

lib/cortex/snippets/view_helpers.rb

@@ -1,40 +1,52 @@
 module Cortex
   module Snippets
     module ViewHelpers
-      def snippet(id)
-        content_tag(:snippet, Client::current_webpage[:snippets].find { |snippet| snippet.name == id }, id: id)
+      def snippet(options = {}, &block)
+        snippet = webpage[:snippets].find { |snippet| snippet.name == options[:id] }
+
+        if snippet.empty?
+          content_tag(:snippet, capture(&block), id: options[:id])
+        else
+          content_tag(:snippet, snippet, id: options[:id])
+        end
       end
 
       def seo_title
-        Client::current_webpage[:seo_title]
+        webpage[:seo_title]
       end
 
       def seo_description
-        Client::current_webpage[:seo_description]
+        webpage[:seo_description]
       end
 
       def noindex
-        Client::current_webpage[:noindex]
+        webpage[:noindex]
       end
 
       def nofollow
-        Client::current_webpage[:nofollow]
+        webpage[:nofollow]
       end
 
       def noodp
-        Client::current_webpage[:noodp]
+        webpage[:noodp]
       end
 
       def nosnippet
-        Client::current_webpage[:nosnippet]
+        webpage[:nosnippet]
       end
 
       def noarchive
-        Client::current_webpage[:noarchive]
+        webpage[:noarchive]
       end
 
       def noimageindex
-        Client::current_webpage[:noimageindex]
+        webpage[:noimageindex]
+      end
+
+      private
+
+      def webpage
+        Client::current_webpage(request)
       end
     end
   end