Rename Write() method on vt to WriteWithCRLFTranslation

Author: UdeshyaDhungana

internal/assertions/highlighting_assertion.go

@@ -46,11 +46,11 @@ func (a *HighlightingAssertion) Run(result executable.ExecutableResult, logger *
 	virtualTerminal2 := virtual_terminal.NewCustomVT(maxTerminalHeight, maxTerminalWidth)
 	defer virtualTerminal2.Close()
 
-	if _, err := virtualTerminal1.Write([]byte(a.ExpectedOutput)); err != nil {
+	if _, err := virtualTerminal1.WriteWithCRLFTranslation([]byte(a.ExpectedOutput)); err != nil {
 		return err
 	}
 
-	if _, err := virtualTerminal2.Write(result.Stdout); err != nil {
+	if _, err := virtualTerminal2.WriteWithCRLFTranslation(result.Stdout); err != nil {
 		return err
 	}
 

virtual_terminal/virtual_terminal.go

@@ -23,13 +23,8 @@ func (vt *VirtualTerminal) Close() {
 	vt.vt.Close()
 }
 
-func (vt *VirtualTerminal) Write(p []byte) (n int, err error) {
-	// TODO: I'll remove this after PR review
-	// Confused about where this (crlf translation) should be put:
-	// Here:
-	// Upsides: The caller doesn't have to perform crlf translation on every write
-	// Downsides: the Write() method may return length different from len(p)
-	// A better way would have been if the vt package had provided a way to enable ONLCR
+func (vt *VirtualTerminal) WriteWithCRLFTranslation(p []byte) (n int, err error) {
+	// The vt package does not provide a way to enable ONLCR on the virtual terminal
 	tr := crlfTranslation(p)
 	return vt.vt.Write(tr)
 }