fix: Add retry logic and error handling for GPP key import (v0.2.8) #66
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit addresses random CI/CD pipeline failures caused by intermittent GPG key import failures when downloading the verification key from keybase.io. Problem: - No error checking on curl command (silent failures) - No retry logic for network failures - No validation that the key was successfully downloaded - No error handling for GPG import failures Solution: - Added retry loop (3 attempts with 2-second delays) - Added explicit error checking for curl with -f flag - Added validation that downloaded key is not empty - Added error checking for GPG import operation - Added informative logging for each attempt Related: codecov/codecov-action#1876
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #66 +/- ##
=======================================
Coverage 97.14% 97.14%
=======================================
Files 2 2
Lines 35 35
=======================================
Hits 34 34
Misses 1 1 ☔ View full report in Codecov by Sentry. |
|
@thomasrockhu-codecov @calvin-codecov This looks good, we have seen this happening occasionally. Any release target to get this merged? |
Comment on lines
-22
to
-23
| else | ||
| CODECOV_COMMAND="${CODECOV_CLI_TYPE}" |
There was a problem hiding this comment.
I don't see an earlier check to make sure CODECOV_COMMAND is guaranteed "codecov-cli" or "sentry-prevent-cli" here like in codecov.sh.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes random CI/CD pipeline failures caused by intermittent GPG key import failures when downloading the verification key from keybase.io.
Problem
This caused random CI/CD pipeline failures for all users, as the verification process would fail unpredictably when network issues occurred or when keybase.io was temporarily unavailable.
Solution
Testing
Related Issues
Release
This includes version bump to 0.2.8