Skip to content

Conversation

@thomasrockhu-codecov
Copy link
Contributor

@thomasrockhu-codecov thomasrockhu-codecov commented Nov 19, 2025

Reverts #572


Note

Switch bundle analysis task chain to pass/accumulate results as a plain list instead of a dict wrapper, updating worker logic, scheduling, and tests accordingly.

  • Worker tasks (Bundle Analysis):
    • Change previous_result type from dict to list[dict] in bundle_analysis_processor and bundle_analysis_notify.
    • Aggregate processing results directly as a list; return and forward lists instead of {"results": ...} wrappers.
    • Early-exit carryforward path returns the accumulated list unchanged.
    • Update scheduling in upload._schedule_bundle_analysis_processing_task to seed the chain with [].
    • Pass the list to measurements saving via previous_result.
  • Tests:
    • Update unit/integration tests to pass lists and assert list returns across processor/notify and upload task chaining.

Written by Cursor Bugbot for commit 6bc89fb. This will update automatically on new commits. Configure here.

@thomasrockhu-codecov thomasrockhu-codecov requested a review from a team November 19, 2025 09:21
@sentry
Copy link

sentry bot commented Nov 19, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.85%. Comparing base (aa50839) to head (6bc89fb).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #576   +/-   ##
=======================================
  Coverage   93.85%   93.85%           
=======================================
  Files        1284     1284           
  Lines       46428    46428           
  Branches     1524     1524           
=======================================
  Hits        43574    43574           
  Misses       2545     2545           
  Partials      309      309           
Flag Coverage Δ
workerintegration 58.57% <20.00%> (ø)
workerunit 91.17% <80.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codecov-notifications
Copy link

codecov-notifications bot commented Nov 19, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@codecov-eu
Copy link

codecov-eu bot commented Nov 19, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@thomasrockhu-codecov thomasrockhu-codecov added this pull request to the merge queue Nov 19, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 19, 2025
@thomasrockhu-codecov thomasrockhu-codecov added this pull request to the merge queue Nov 19, 2025
Merged via the queue into main with commit 061ed90 Nov 19, 2025
41 checks passed
@thomasrockhu-codecov thomasrockhu-codecov deleted the revert-572-revert-565-th/use-list-for-bundle-analysis branch November 19, 2025 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants