Add block files to Eslint configuration file #184
Conversation
![codacy-production[bot]](https://avatars.githubusercontent.com/in/56611?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
There was a problem hiding this comment.
Pull Request Overview
Small change: added a files array to the generated ESLint config to include many file extensions (js/jsx/ts/tsx/mjs/cjs/vue). No Codacy issues were raised. Review focuses on correctness, maintainability, and potential missing extensions or escaping concerns.
About this PR
Good to restrict rules to specific file types. Ensure this list matches the project's actual source file types (e.g., .jsx/.tsx usage, .mjs/.cjs presence). Consider centralizing the extensions list if used elsewhere to avoid duplication.
Low risk | High confidence
💡 Codacy uses AI. Check for mistakes.
| func CreateEslintConfig(toolsConfigDir string, configuration []domain.PatternConfiguration) error { | ||
| result := `export default [ | ||
| { | ||
| files: ["**/*.js", "**/*.jsx", "**/*.ts", "**/*.tsx", "**/*.mjs", "**/*.cjs", "**/*.vue"], |
There was a problem hiding this comment.
[Suggestion] You added files: ["**/*.js", "**/*.jsx", "**/*.ts", "**/*.tsx", "**/*.mjs", "**/*.cjs", "**/*.vue"]. Confirm that: (1) you want to include both .mjs and .cjs (commonjs vs ESM) — including both is fine but unnecessary if your repo uses only one; (2) any other extensions (e.g. .cts/.mts, .jsx in .tsx projects, or framework specific extensions) are not needed. If this list may grow, extract into a constant or a small helper to keep the template string clearer.
Medium risk | Medium confidence
No description provided.