create new test to check relative paths

Author: DMarinhoCodacy

cmd/upload.go

@@ -60,7 +60,6 @@ var sarifShortNameMap = map[string]string{
 	"revive":              "revive",
 }
 
-// Helper to look up the short name
 func getToolShortName(fullName string) string {
 	if shortName, ok := sarifShortNameMap[fullName]; ok {
 		return shortName

cmd/upload_test.go

@@ -0,0 +1,77 @@
+package cmd
+
+import (
+	"path/filepath"
+	"testing"
+
+	"github.com/stretchr/testify/assert"
+)
+
+func TestGetRelativePath(t *testing.T) {
+	const baseDir = "/home/user/project/src"
+
+	tests := []struct {
+		name     string
+		baseDir  string
+		fullURI  string
+		expected string
+	}{
+		{
+			name:     "1. File URI with standard path",
+			baseDir:  baseDir,
+			fullURI:  "file:///home/user/project/src/lib/file.go",
+			expected: "lib/file.go",
+		},
+		{
+			name:     "2. File URI with baseDir as the file path",
+			baseDir:  baseDir,
+			fullURI:  "file:///home/user/project/src",
+			expected: ".",
+		},
+		{
+			name:     "3. Simple path (no scheme)",
+			baseDir:  baseDir,
+			fullURI:  "/home/user/project/src/main.go",
+			expected: "main.go",
+		},
+		{
+			name:    "4. URI outside baseDir (should return absolute path if relative fails)",
+			baseDir: baseDir,
+			fullURI: "file:///etc/config/app.json",
+			// This is outside of baseDir, so we expect the absolute path starting from the baseDir root
+			expected: "../../../../etc/config/app.json",
+		},
+		{
+			name:     "5. Plain URI with different scheme (should be treated as plain path)",
+			baseDir:  baseDir,
+			fullURI:  "http://example.com/api/v1/file.go",
+			expected: "http://example.com/api/v1/file.go",
+		},
+		{
+			name:     "6. Empty URI",
+			baseDir:  baseDir,
+			fullURI:  "",
+			expected: "",
+		},
+		{
+			name:     "7. Windows path on a file URI (should correctly strip the leading slash from the path component)",
+			baseDir:  "C:\\Users\\dev\\repo",
+			fullURI:  "file:///C:/Users/dev/repo/app/main.go",
+			expected: "/C:/Users/dev/repo/app/main.go",
+		},
+		{
+			name:     "8. URI with spaces (URL encoded)",
+			baseDir:  baseDir,
+			fullURI:  "file:///home/user/project/src/file%20with%20spaces.go",
+			expected: "file with spaces.go",
+		},
+	}
+
+	for _, tt := range tests {
+		t.Run(tt.name, func(t *testing.T) {
+			actual := getRelativePath(tt.baseDir, tt.fullURI)
+			expectedNormalized := filepath.FromSlash(tt.expected)
+			assert.Equal(t, expectedNormalized, actual, "Relative path should match expected")
+		})
+	}
+}

codacy-client/client_test.go

@@ -2,7 +2,6 @@ package codacyclient
 
 import (
 	"encoding/json"
-	"fmt"
 	"net/http"
 	"net/http/httptest"
 	"testing"
@@ -108,48 +107,3 @@ func TestGetToolPatternsConfig_Empty(t *testing.T) {
 	assert.NoError(t, err)
 	assert.Empty(t, patterns)
 }
-
-func TestGetToolPatternsConfig_WithNonRecommended(t *testing.T) {
-
-	config := []domain.PatternDefinition{
-		{
-			Id:      "internal_id_1",
-			Enabled: true,
-		},
-		{
-			Id:      "internal_id_2",
-			Enabled: false,
-		},
-	}
-
-	ts := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
-
-		resp := map[string]interface{}{
-			"data":       config,
-			"pagination": map[string]interface{}{"cursor": ""},
-		}
-		w.Header().Set("Content-Type", "application/json")
-		json.NewEncoder(w).Encode(resp)
-	}))
-	defer ts.Close()
-
-	expected := []domain.PatternConfiguration{
-		{
-			Enabled: true,
-			PatternDefinition: domain.PatternDefinition{
-				Id:      "internal_id_1",
-				Enabled: true,
-			},
-		},
-	}
-
-	CodacyApiBase = ts.URL
-
-	initFlags := domain.InitFlags{ApiToken: "dummy"}
-	patterns, err := GetToolPatternsConfigWithCodacyAPIBase(CodacyApiBase, initFlags, "tool-uuid", true)
-
-	fmt.Println(len(patterns))
-
-	assert.NoError(t, err)
-	assert.Equal(t, expected, patterns)
-}