add test

Author: DMarinhoCodacy

cmd/analyze.go

@@ -312,6 +312,7 @@ func checkIfConfigExistsAndIsNeeded(toolName string, cliLocalMode bool) error {
 	// Use the configuration system to get the tools config directory
 	toolsConfigDir := config.Config.ToolsConfigDirectory()
 	toolConfigPath := filepath.Join(toolsConfigDir, configFileName)
+
 	// Check if the config file exists
 	if _, err := os.Stat(toolConfigPath); os.IsNotExist(err) {
 		// Config file does not exist - create it if we have the means to do so

cmd/configsetup/repository_config.go

@@ -93,7 +93,6 @@ func createToolConfigurationFiles(tools []domain.Tool, flags domain.InitFlags) e
 // CreateToolConfigurationFile creates a configuration file for a single tool
 func CreateToolConfigurationFile(toolName string, flags domain.InitFlags) error {
 	// Find the tool UUID by tool name
-	fmt.Printf("Creating configuration file for tool %s\n", toolName)
 	toolUUID := getToolUUIDByName(toolName)
 	if toolUUID == "" {
 		return fmt.Errorf("tool '%s' not found in supported tools", toolName)

tools/lizard/lizardRunner.go

@@ -21,6 +21,7 @@ func RunLizard(workDirectory string, binary string, files []string, outputFile s
 	configFile, exists := tools.ConfigFileExists(config.Config, "lizard.yaml")
 	var patterns []domain.PatternDefinition
 	var errConfigs error
+
 	if exists {
 		// Configuration exists, read from file
 		patterns, errConfigs = ReadConfig(configFile)
@@ -34,6 +35,7 @@ func RunLizard(workDirectory string, binary string, files []string, outputFile s
 			return fmt.Errorf("failed to fetch default patterns: %v", errConfigs)
 		}
 	}
+
 	if len(patterns) == 0 {
 		return fmt.Errorf("no valid patterns found in configuration")
 	}

tools/runnerUtils_test.go

@@ -35,6 +35,37 @@ func TestConfigFileExistsInToolsConfigDirectory(t *testing.T) {
 		"Config path should be correctly formed relative path")
 }
 
+func TestConfigFilePrefersToolsConfigDirectory(t *testing.T) {
+	// Create a test directory structure
+	tempDir := t.TempDir()
+	repoDir := filepath.Join(tempDir, "src")
+	repositoryCache := filepath.Join(repoDir, ".codacy")
+
+	// Create configuration
+	config := *config.NewConfigType(repoDir, repositoryCache, "unused-global-cache")
+
+	// Create .codacy/tools-configs directory
+	configDir := filepath.Join(repoDir, ".codacy", "tools-configs")
+	err := os.MkdirAll(configDir, 0755)
+	assert.NoError(t, err, "Failed to create test directory structure")
+
+	// Create a test config file in both locations
+	generatedConfigFile := filepath.Join(configDir, "some-config.yaml")
+	existingConfigFile := filepath.Join(repoDir, "some-config.yaml")
+
+	err = os.WriteFile(generatedConfigFile, []byte("tools config content"), 0644)
+	assert.NoError(t, err, "Failed to create test config file in tools config directory")
+
+	err = os.WriteFile(existingConfigFile, []byte("repository config content"), 0644)
+	assert.NoError(t, err, "Failed to create test config file in repository directory")
+
+	// Test case: Config file in tools config directory is preferred
+	configPath, exists := ConfigFileExists(config, "some-config.yaml")
+	assert.True(t, exists, "Config file should exist")
+	assert.Equal(t, filepath.Join(config.ToolsConfigDirectory(), "some-config.yaml"), configPath,
+		"Config path should prefer tools config directory")
+}
+
 func TestConfigFileExistsInRepositoryDirectory(t *testing.T) {
 	// Create a test directory structure
 	tempDir := t.TempDir()