Skip to content

Migration failed due to missing kwargs in workflow hash #134

@anthotsang

Description

@anthotsang

Received the following error when trying to perform the migration when upgrading to v4.1.0 (albeit from a very old v2.1.0), but it seems like this issue was introduced in v4.0.0 in this pull request.

Migrating to Gush::IndexWorkflowsByCreatedAtAndExpiresAt (1)
bundler: failed to load command: gush (/app/vendor/bundle/ruby/3.2.0/bin/gush)
/app/vendor/bundle/ruby/3.2.0/gems/gush-4.1.0/lib/gush/client.rb:284:in `workflow_from_hash': no implicit conversion of nil into Hash (TypeError)
	from /app/vendor/bundle/ruby/3.2.0/gems/gush-4.1.0/lib/gush/client.rb:142:in `find_workflow'
	from /app/vendor/bundle/ruby/3.2.0/gems/gush-4.1.0/lib/gush/migrate/1_create_gush_workflows_created.rb:10:in `block in up'
	from /app/vendor/bundle/ruby/3.2.0/gems/redis-5.4.1/lib/redis/commands/keys.rb:59:in `each'
	from /app/vendor/bundle/ruby/3.2.0/gems/redis-5.4.1/lib/redis/commands/keys.rb:59:in `block in scan_each'
	from /app/vendor/bundle/ruby/3.2.0/gems/redis-5.4.1/lib/redis/commands/keys.rb:57:in `loop'
	from /app/vendor/bundle/ruby/3.2.0/gems/redis-5.4.1/lib/redis/commands/keys.rb:57:in `scan_each'
	from /app/vendor/bundle/ruby/3.2.0/gems/gush-4.1.0/lib/gush/migrate/1_create_gush_workflows_created.rb:8:in `each'
	from /app/vendor/bundle/ruby/3.2.0/gems/gush-4.1.0/lib/gush/migrate/1_create_gush_workflows_created.rb:8:in `map'
	from /app/vendor/bundle/ruby/3.2.0/gems/gush-4.1.0/lib/gush/migrate/1_create_gush_workflows_created.rb:8:in `up'
	from /app/vendor/bundle/ruby/3.2.0/gems/gush-4.1.0/lib/gush/migration.rb:6:in `migrate'
	from /app/vendor/bundle/ruby/3.2.0/gems/gush-4.1.0/lib/gush/cli.rb:137:in `block in migrate'
	from /app/vendor/bundle/ruby/3.2.0/gems/gush-4.1.0/lib/gush/cli.rb:132:in `count'
	from /app/vendor/bundle/ruby/3.2.0/gems/gush-4.1.0/lib/gush/cli.rb:132:in `migrate'
	from /app/vendor/bundle/ruby/3.2.0/gems/thor-1.2.2/lib/thor/command.rb:27:in `run'
	from /app/vendor/bundle/ruby/3.2.0/gems/thor-1.2.2/lib/thor/invocation.rb:127:in `invoke_command'
	from /app/vendor/bundle/ruby/3.2.0/gems/thor-1.2.2/lib/thor.rb:392:in `dispatch'
	from /app/vendor/bundle/ruby/3.2.0/gems/thor-1.2.2/lib/thor/base.rb:485:in `start'
	from /app/vendor/bundle/ruby/3.2.0/gems/gush-4.1.0/bin/gush:13:in `<top (required)>'
	from /app/vendor/bundle/ruby/3.2.0/bin/gush:25:in `load'
	from /app/vendor/bundle/ruby/3.2.0/bin/gush:25:in `<top (required)>'
	from /app/vendor/bundle/ruby/3.2.0/gems/bundler-2.5.23/lib/bundler/cli/exec.rb:58:in `load'
	from /app/vendor/bundle/ruby/3.2.0/gems/bundler-2.5.23/lib/bundler/cli/exec.rb:58:in `kernel_load'
	from /app/vendor/bundle/ruby/3.2.0/gems/bundler-2.5.23/lib/bundler/cli/exec.rb:23:in `run'
	from /app/vendor/bundle/ruby/3.2.0/gems/bundler-2.5.23/lib/bundler/cli.rb:456:in `exec'
	from /app/vendor/bundle/ruby/3.2.0/gems/bundler-2.5.23/lib/bundler/vendor/thor/lib/thor/command.rb:28:in `run'
	from /app/vendor/bundle/ruby/3.2.0/gems/bundler-2.5.23/lib/bundler/vendor/thor/lib/thor/invocation.rb:127:in `invoke_command'
	from /app/vendor/bundle/ruby/3.2.0/gems/bundler-2.5.23/lib/bundler/vendor/thor/lib/thor.rb:527:in `dispatch'
	from /app/vendor/bundle/ruby/3.2.0/gems/bundler-2.5.23/lib/bundler/cli.rb:35:in `dispatch'
	from /app/vendor/bundle/ruby/3.2.0/gems/bundler-2.5.23/lib/bundler/vendor/thor/lib/thor/base.rb:584:in `start'
	from /app/vendor/bundle/ruby/3.2.0/gems/bundler-2.5.23/lib/bundler/cli.rb:29:in `start'
	from /app/vendor/bundle/ruby/3.2.0/gems/bundler-2.5.23/exe/bundle:28:in `block in <top (required)>'
	from /app/vendor/bundle/ruby/3.2.0/gems/bundler-2.5.23/lib/bundler/friendly_errors.rb:117:in `with_friendly_errors'
	from /app/vendor/bundle/ruby/3.2.0/gems/bundler-2.5.23/exe/bundle:20:in `<top (required)>'
	from /app/bin/bundle:108:in `load'
	from /app/bin/bundle:108:in `<main>'

If a default is provided for hash[:kwargs] in workflow_from_hash here, it should solve the issue.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions