[MNG-5984] Maven core extension resolution ignores repositories from activeByDefault profiles in settings.xml

[jira-importer]

Gabriël Konat opened MNG-5984 and commented

When building a project with a core extension in .mvn/extensions.xml, where the core extension is not installed locally but needs to be retrieved from a remote repository, profiles from settings.xml with repositories which are <activeByDefault>true</activeByDefault>, are ignored, failing the resolution of the core extension.

If the profile is activated from within an activeProfiles section, they are not ignored and resolution succeeds.

Concrete example:

<?xml version="1.0" encoding="UTF-8"?>
<extensions>
  <extension>
    <groupId>org.metaborg</groupId>
    <artifactId>spoofax-maven-plugin-pomless</artifactId>
    <version>2.0.0-SNAPSHOT</version>
  </extension>
</extensions>

<?xml version="1.0" ?>
<settings
  xmlns="http://maven.apache.org/SETTINGS/1.0.0"
  xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
  xsi:schemaLocation="http://maven.apache.org/SETTINGS/1.0.0 http://maven.apache.org/xsd/settings-1.0.0.xsd"
>
  <profiles>
    <profile>
      <id>add-metaborg-snapshot-repos</id>
      <activation>
        <activeByDefault>true</activeByDefault>
      </activation>
      <repositories>
        <repository>
          <id>metaborg-snapshot-repo</id>
          <url>http://artifacts.metaborg.org/content/repositories/snapshots/</url>
          <releases>
            <enabled>false</enabled>
          </releases>
          <snapshots>
            <enabled>true</enabled>
          </snapshots>
        </repository>
      </repositories>
      <pluginRepositories>
        <pluginRepository>
          <id>metaborg-snapshot-repo</id>
          <url>http://artifacts.metaborg.org/content/repositories/snapshots/</url>
          <releases>
            <enabled>false</enabled>
          </releases>
          <snapshots>
            <enabled>true</enabled>
          </snapshots>
        </pluginRepository>
      </pluginRepositories>
    </profile>
  </profiles>
</settings>

Results in failed resolution:

[WARNING] The POM for org.metaborg:spoofax-maven-plugin-pomless:jar:2.0.0-SNAPSHOT is missing, no dependency information available
[WARNING] Failed to read extensions descriptor /Users/gohla/spoofax/master/repo/spoofax-releng/sdf/org.metaborg.meta.lang.sdf/.mvn/extensions.xml: Plugin org.metaborg:spoofax-maven-plugin-pomless:2.0.0-SNAPSHOT or one of its dependencies could not be resolved: Could not find artifact org.metaborg:spoofax-maven-plugin-pomless:jar:2.0.0-SNAPSHOT

Whereas with the following settings file it succeeds to resolve the core extension:

<?xml version="1.0" ?>
<settings
  xmlns="http://maven.apache.org/SETTINGS/1.0.0"
  xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
  xsi:schemaLocation="http://maven.apache.org/SETTINGS/1.0.0 http://maven.apache.org/xsd/settings-1.0.0.xsd"
>
  <profiles>
    <profile>
      <id>add-metaborg-snapshot-repos</id>
      <repositories>
        <repository>
          <id>metaborg-snapshot-repo</id>
          <url>http://artifacts.metaborg.org/content/repositories/snapshots/</url>
          <releases>
            <enabled>false</enabled>
          </releases>
          <snapshots>
            <enabled>true</enabled>
          </snapshots>
        </repository>
      </repositories>
      <pluginRepositories>
        <pluginRepository>
          <id>metaborg-snapshot-repo</id>
          <url>http://artifacts.metaborg.org/content/repositories/snapshots/</url>
          <releases>
            <enabled>false</enabled>
          </releases>
          <snapshots>
            <enabled>true</enabled>
          </snapshots>
        </pluginRepository>
      </pluginRepositories>
    </profile>
  </profiles>
  <activeProfiles>
    <activeProfile>add-metaborg-snapshot-repos</activeProfile>
  </activeProfiles>
</settings>

---

Affects: 3.3.9

Issue Links:

• MNG-7115 MavenITmng5771CoreExtensionsTest fails on maven-3.8.x branch

• MNG-6327 Add ability to easily retrieve core extensions from alternative pluginRepository

• MNG-7018 Maven does not traverse all repos when downloading extensions from .mvn/extensions.xml

Remote Links:

• Page
  

1 votes, 12 watchers

[jira-importer]

Christian Schulte commented

Can you please test the problem is solved in a current 3.4.0-SNAPSHOT.

[jira-importer]

Gabriël Konat commented

Yes, it is fixed in the latest 3.4.0-SNAPSHOT, thanks!

[jira-importer]

Stephen Connolly commented

Maven 3.4.0 has been dropped. See this thread for more details.

This issue will need to be re-scheduled for a Maven release in the (hopefully near) future.

[jira-importer]

Christian Schulte commented

Issue is fixed in the master branch of my private maven repository on github. When interested, you can cherry pick the commit to your own repository and create a pull request for the apache master branch with just this commit yourself from there.

[jira-importer]

Michael Osipov commented

Gohla, do you think you could bundle up a sample project for this? I'd like to turn this into an IT.

[jira-importer]

Christian Schulz commented

Still open in Maven 3.5.2.

It also ignores the mirror in a settings.xml, I have to add the pluginRepository to get the build extension resolved.

For me it is not clear, why pluginRepository works and not normal repository, because I can't find any hint, that the build extensions are resolved via pluginRepository settings.

[jira-importer]

Francois MAROT commented

I can confirm the problem is still in Maven 3.5.3: relying on "activeByDefault" to fetch extensions from the repo is KO but referencing the profile in the "activeProfiles" section enables Maven to find the extension. Thanks for this bug request because without it I'd be still wondering why it was not working as expected...

[jira-importer]

Slawomir Jaranowski commented

I think, cause problem for this is that evaluation for profile activation is done during project model building.

It happen after settings process and after extensions is loaded.

During settings process only activeProfiles tags is regognized.

So repositories from profile settings is not included.