[MNG-5359] Declared execution in PluginMgmt gets bound to lifecycle (regression)

[jira-importer]

Anders Hammar opened MNG-5359 and commented

If a plugin execution binding is declared in pluginManagement it gets bound to the build lifecycle in Maven 3.0.x, but not with Maven 2.2.1.
My understanding is that the behavior in Maven 3.0 is wrong; an execution binding needs to be declared in build/plugins/plugin to be bound.

---

Affects: 3.0.1, 3.0.2, 3.0.3, 3.0.4

Attachments:

• binding-test.zip (5.17 kB)
• MNG-5359-IT.patch (5.64 kB)

Issue Links:

• MNG-6284 <executions> inside <pluginManagement> should raise a warning
  ("causes")

Remote Links:

• Page
  
• GitHub Pull Request #27
  
• GitHub Pull Request #143
  
• GitHub Pull Request #27
  

0 votes, 7 watchers

[jira-importer]

Anders Hammar commented

I'm attaching a test project that shows how the clean mojo incorrectly gets bound to the validate phase when the project is executed with Maven 3.0. But not when executed with Maven 2.2.1.

[jira-importer]

Anders Hammar commented

Some investigation shows that this seems specific to the clean plugin (doesn't happen for the enforcer plugin for example). I'm guessing this is because the clean plugin has bindings to the clean lifecycle.

[jira-importer]

Anders Hammar commented

IT attached.
Need to add to the test suite as well, and also possibly alter the Maven version range it should be performed on depending on when fixed.

[jira-importer]

Anders Hammar commented

Unfortunately it looks like this issues will require some larger code fix in core. I don't really have this in-depth core knowledge currently, so I'm unassigning myself.

[jira-importer]

Jason van Zyl commented

Please refer to https://cwiki.apache.org/confluence/display/MAVEN/The+Great+JIRA+Cleanup+of+2014

[jira-importer]

Jason van Zyl commented

Please refer to https://cwiki.apache.org/confluence/display/MAVEN/The+Great+JIRA+Cleanup+of+2014 if you're wondering why this issue was closed out.

[jira-importer]

Anders Hammar commented

Re-opening as there is an IT attached.

[jira-importer]

Christian Schulte commented

The cause of this is the way 'org.apache.maven.model.plugin.DefaultLifecycleBindingsInjector' injects plugins. It will use the plugins of the lifecycle corresponding to the packaging of the project and all plugins of all lifecycles declaring default phases. That is the 'clean' lifecycle and the 'site' lifecycle. The 'clean' lifecycle has

<default-phases>
  <clean>
    org.apache.maven.plugins:maven-clean-plugin:2.5:clean
  </clean>
</default-phases>

and the 'site' lifecycle has

<default-phases>
  <site>
    org.apache.maven.plugins:maven-site-plugin:3.3:site
  </site>
  <site-deploy>
    org.apache.maven.plugins:maven-site-plugin:3.3:deploy
  </site-deploy>
</default-phases>

The only plugins added to 'build/plugins/plugin' and thus merged with any plugin management should be the plugins requested to be executed by the user. Class 'org.apache.maven.lifecycle.Lifecycle' declares:

public Map<String, LifecyclePhase> getDefaultLifecyclePhases()
{
    return defaultPhases;
}
@Deprecated
public Map<String, String> getDefaultPhases()
{
    return LifecyclePhase.toLegacyMap( getDefaultLifecyclePhases() );
}

The only usage of these methods is in class 'DefaultLifecycleBindingsInjector'. Can someone explain what 'Lifecycle.getDefaultLifecyclePhases()' and 'Lifecycle.getDefaultPhases()' is/was used for? Is this the only use case?

[jira-importer]

Christian Schulte commented

Re-opening for further discussion. This probably cannot be fixed without breaking Maven 3 backwards compatibility. It's also not clear what the correct behaviour should be. For example:

Apache Maven 2.2.1 (r801777; 2009-08-06 21:16:01+0200)

mvn validate

[INFO] No goals needed for project - skipping

mvn clean

[INFO] [clean:clean {execution: default-clean}]

mvn clean validate

[INFO] [clean:clean {execution: default-clean}]
[INFO] [clean:clean {execution: auto-clean}]

Looking at the last execution ('clean validate'), are you sure the 'auto-clean' execution should be executed by Maven 2.2.1? Maven is told to execute the clean lifecycle followed by the default lifecycle. The 'clean' plugin is not added to 'build/plugins/plugin' so should no execute during the default lifecycle with Maven 2.2.1 as well, IMHO.

[jira-importer]

Stephen Connolly commented

Maven 3.4.0 has been dropped. See this thread for more details.

This issue will need to be re-scheduled for a Maven release in the (hopefully near) future.

[jira-importer]

Christian Schulte commented

Issue is fixed in the master branch of my private maven repository on github. When interested, you can cherry pick the commit to your own repository and create a pull request for the apache master branch with just this commit yourself from there.