Proposal to fix support for mirrors #399
Conversation
This change relies on reusing existing API that can return proper URL (as set by user by ANY means in Maven config) to resolve from. Moreover, if repo ID is made configurable as well, it could be used to pull (needs more code) reposes like ID "my-corpo-repo" from settings and use that instead.
| /** | ||
| * Ctor for UT. | ||
| */ | ||
| public WrapperMojo(RepositorySystem system, RepositorySystemSession session) { |
There was a problem hiding this comment.
As we have a constructor we can inject all needed components ...
|
Thank you for this, If this is better solution I am all for it.
Sorry, I’m not familiar with this and I’m unsure what the next steps are or what you mean with this. For what is worth, I built and tested this locally and it seems to fix my original bug report, so I'd be happy to have this as an starting solution
|
3 participants
This change relies on reusing existing API that can return proper URL (as set by user by ANY means in Maven config) to resolve from.
Moreover, if repo ID is made configurable as well, it could be used to pull (needs more code; for that you would need to pull exec req repo by ID, and use that instead, and not craft central RemoteRepository instance) reposes like ID "my-corpo-repo" from settings and use that instead.
@laeubi @yeikel
Am leaving this PR as draft and you can work it out based on this.
Fixes #396
Supersedes #397