IGNITE-27033: checkpoint control.sh command #12547
Conversation
| import org.apache.ignite.internal.management.api.ComputeCommand; | ||
| import org.jetbrains.annotations.Nullable; | ||
|
|
||
| public class CheckpointForceCommand implements ComputeCommand<CheckpointForceCommandArg, String> { |
There was a problem hiding this comment.
This logic must be in CheckpointCommand itself.
So the desired syntax is:
> ./control.sh --checkpoint
> ./control.sh --checkpoint --reason "After data load checkpoint"
> ./control.sh --checkoint --wait-for-finish --timeout 60000
| } | ||
|
|
||
| /** {@inheritDoc} */ | ||
| @Override protected String run(@Nullable CheckpointForceCommandArg arg) throws IgniteException { |
There was a problem hiding this comment.
We must check if persistence enabled on node with the:
if (!CU.isPersistenceEnabled(ignite.configuration())) {
throw new IgniteException("Can't checkpoint on in-memory node"); // Or return some result here.
}
|
@DEADripER please, fix code style violations. |
|
| import org.apache.ignite.internal.management.api.ComputeCommand; | ||
| import org.jetbrains.annotations.Nullable; | ||
|
|
||
| /** Checkpoint command class*/ |
There was a problem hiding this comment.
typo: /** Checkpoint command class*/ -> /** Checkpoint command. */
| CheckpointProgress checkpointfut = dbMgr.forceCheckpoint(reason); | ||
|
|
||
| if (waitForFinish) { | ||
| if (timeout != null && timeout > 0) { |
There was a problem hiding this comment.
if (timeout != null && timeout > 0)
checkpointfut.futureFor(CheckpointState.FINISHED).get(timeout, TimeUnit.MILLISECONDS);
else
checkpointfut.futureFor(CheckpointState.FINISHED).get();
| } | ||
| return "Checkpoint completed on node: " + ignite.localNode().id(); | ||
| } | ||
| else { |
There was a problem hiding this comment.
else
return "Checkpoint triggered on node: " + ignite.localNode().id();
|
|
||
| /** {@inheritDoc} */ | ||
| @Override protected String run(@Nullable CheckpointCommandArg arg) throws IgniteException { | ||
| if (!CU.isPersistenceEnabled(ignite.configuration())) { |
There was a problem hiding this comment.
One line statements written without quote.
Please, take a look at style guide:
https://cwiki.apache.org/confluence/display/IGNITE/Coding+Guidelines
if (!CU.isPersistenceEnabled(ignite.configuration()))
throw new IgniteException("Can't checkpoint on in-memory node");
| throw new IgniteException("Can't checkpoint on in-memory node"); | ||
| } | ||
|
|
||
| String reason = arg != null && arg.reason() != null ? arg.reason() : "control.sh"; |
There was a problem hiding this comment.
Let's skip arg null checks here and in other places.
| } | ||
|
|
||
| /** {@inheritDoc} */ | ||
| @Override protected String run(@Nullable CheckpointCommandArg arg) throws IgniteException { |
There was a problem hiding this comment.
Please, remove Nullable annotation.
| stopAllGrids(); | ||
| cleanPersistenceDir(); | ||
| injectTestSystemOut(); | ||
| super.beforeTest(); |
There was a problem hiding this comment.
super.beforeTest(); must be invoked first.
| @Override protected IgniteConfiguration getConfiguration(String igniteInstanceName) throws Exception { | ||
| IgniteConfiguration cfg = super.getConfiguration(igniteInstanceName); | ||
|
|
||
| if (clusterState == 1) |
There was a problem hiding this comment.
Let's use
GridCommandHandlerAbstractTest#persistenceEnable instead of clusterState flag
3 participants
Thank you for submitting the pull request to the Apache Ignite.
In order to streamline the review of the contribution
we ask you to ensure the following steps have been taken:
The Contribution Checklist
The description explains WHAT and WHY was made instead of HOW.
The following pattern must be used:
IGNITE-XXXX Change summarywhereXXXX- number of JIRA issue.(see the Maintainers list)
the
green visaattached to the JIRA ticket (see TC.Bot: Check PR)Notes
If you need any help, please email [email protected] or ask anу advice on http://asf.slack.com #ignite channel.