the optiona keyword "FIELDS" inside insert statements was not accepted by PL/SQL parser #4684
+49
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…less, but supported by oracle) keyword "FIELDS" (e.g.: INSERT INTO tabname FIELDS (....) VALUES(...) ) added "AUDIT" as valid identifier name (for example in plsql variable declarations)
… be used also as variable names in variable declarations
…) procedures also in the create package spec command: the grammar did allow them only in the package body (I am referring to declarations like "procedure MyJavaProc as JAVA 'javaclass.staticmethodname'; "
… output parameters)
…ameter. clearly this is an error: it is perfectly fine to have parameterless member procedures
…y "IN" was not allowed, moreover, some complex expression types (like myarray(5).myvalue) were not allowed
…unction overriding was implemented
…unctions was missing support for IN/OUT/NOCOPY specifiers and for default values
…pl/sql bock. the grammar was expecting at least one declaration
Member
|
@csm101 thanks |
Member
|
@csm101 could you please add some test data that cover the changes in grammar? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Oracle accepts an optional (and useless...) keyword "FIELDS" in insert statements, like in this example
INSERT INTO mytable FIELDS (myfield) VALUES ('myvalue');
the grammar did not accept this FIELDS keyword.
Moreover: it is actually possible do declare a plsql variable named "AUDIT" even if AUDIT is a keyword: this compiles just fine for oracle:
declare
audit CLOB;
begin
....
end;
but this wasn't accepted by the grammar. I fixed it too