Skip to content

[eiffel] Examples contains eiffel-2-eiffel/ driver app, and symbolic link, which isn't supported on Windows! #4694

@kaby76

Description

@kaby76

I was just fixing #4690, and notice that there is a file that is a symbolic link: https://github.com/antlr/grammars-v4/blob/f4b7e36bcf8345206e74f1020d28523f3dcfc0ab/eiffel/examples/eiffel-2-eiffel/Eiffel.g4. We can't have symbolic links because they don't work on Windows at least with this repo. So, we need a check in the build to make sure this doesn't happen anymore.

Further, I don't know why the examples inputs contains an Antlr driver application. It's not needed, and certainly causes confusion. What is EiffelGrammar.g4, and how is it different than Eiffel.g4?? The driver program is only for Java, and only works on a Unix box, not Windows. It needs to be deleted.

The code review comment was ignored, and the grammar checked in. It should not have been ignored. #3976 (review)

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions