MCP-175 Support reaching localhost from within the container #119
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nquinquenel
requested review from
sophio-japharidze-sonarsource and
vnaskos-sonar
nquinquenel
force-pushed
the
bug/nq/MCP-175-localhost-issue
branch
from
650e99b to
32fe46a
Compare
sophio-japharidze-sonarsource
left a comment
sophio-japharidze-sonarsource
left a comment
There was a problem hiding this comment.
Looks good. Will approve as soon I can confirm that it works
src/main/java/org/sonarsource/sonarqube/mcp/configuration/McpServerLaunchConfiguration.java
Outdated
Show resolved
Hide resolved
nquinquenel
force-pushed
the
bug/nq/MCP-175-localhost-issue
branch
from
32fe46a to
81c3377
Compare
sophio-japharidze-sonarsource
approved these changes
Oct 23, 2025
sophio-japharidze-sonarsource
left a comment
sophio-japharidze-sonarsource
left a comment
There was a problem hiding this comment.
LGTM! Also tested locally & it works
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MCP-175