SLVS-2383 Testing different credential store implementations

[georgii-borovinskikh-sonarsource]

SLVS-2383

Part of

[sonarqubecloud]

Quality Gate failed

Failed conditions
5 New issues
0.0% Coverage on New Code (required ≥ 85%)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

[sonarqubecloud]

SonarQube reviewer guide

Summary: Add support for multiple credential storage implementations including DPAPI-based and master password-based encryption methods.

Review Focus: The credential storage refactoring is complex - examine the new credential loader abstraction (ISolutionBindingCredentialsLoader), aggregation pattern, and encryption implementations. Pay special attention to the master password dialog flow and how credentials are migrated between storage types. Several test files are commented out rather than updated, which needs addressing.

Start review at: src/ConnectedMode/Persistence/AggregatingSolutionBindingCredentialsLoader.cs. This is the orchestration layer that delegates to specific credential store implementations based on settings and establishes the pattern for the entire feature.

💬 Please send your feedback

Quality Gate failed

Failed conditions
16 New issues
0.0% Coverage on New Code (required ≥ 80%)
15.9% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE