SONARJAVA-5184 Suppress boxed Boolean warnings on @NonNull parameters. #4931
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hashicorp-vault-sonar-prod
bot
changed the title
tomasz-tylenda-sonarsource
force-pushed
the
tt/boxed-boolean-lambda
branch
2 times, most recently
from
9c1008c to
1049b38
Compare
tomasz-tylenda-sonarsource
requested a review
from leonardo-pilastri-sonarsource
leonardo-pilastri-sonarsource
approved these changes
Nov 20, 2024
Contributor
leonardo-pilastri-sonarsource
left a comment
leonardo-pilastri-sonarsource
left a comment
There was a problem hiding this comment.
Looks good! I just left a comment on some useless parenthesis, but it might be debatable if they make the code more readable or not. I would personally remove them
java-checks/src/main/java/org/sonar/java/checks/BoxedBooleanExpressionsCheck.java
Outdated
Show resolved
Hide resolved
…pressionsCheck.java Co-authored-by: leonardo-pilastri-sonarsource <[email protected]>
tomasz-tylenda-sonarsource
force-pushed
the
tt/boxed-boolean-lambda
branch
from
73edd5f to
b5969b1
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SONARJAVA-5184