JS-914 Enforce usage of suggestions and fixes on all rules (#5853)

Author: vdiez

packages/jsts/src/rules/S1082/rule.ts

@@ -26,7 +26,6 @@ const clickEventsHaveKeyEvents = rules['click-events-have-key-events'];
 
 export const rule: Rule.RuleModule = {
   meta: generateMeta(meta, {
-    hasSuggestions: true,
     messages: {
       ...mouseEventsHaveKeyEvents.meta!.messages,
       ...clickEventsHaveKeyEvents.meta!.messages,

packages/jsts/src/rules/S1105/meta.ts

@@ -18,3 +18,4 @@ export const implementation = 'decorated';
 export const eslintId = 'brace-style';
 export const externalRules = [{ externalPlugin: 'eslint', externalRule: 'brace-style' }];
 export * from './config.js';
+export const quickFixMessage = 'Follow curly brace style';

packages/jsts/src/rules/S1940/rule.ts

@@ -40,7 +40,6 @@ export const rule: Rule.RuleModule = {
       suggestOperationInversion: 'Invert inner operation (apply if NaN is not expected)',
     },
     hasSuggestions: true,
-    fixable: 'code',
   }),
   create(context) {
     return {

packages/jsts/src/rules/S3723/meta.ts

@@ -17,3 +17,4 @@
 export const implementation = 'original';
 export const eslintId = 'enforce-trailing-comma';
 export * from './config.js';
+export const quickFixMessage = 'Add trailing comma';

packages/jsts/src/rules/S5254/rule.ts

@@ -36,7 +36,6 @@ function decorate(rule: Rule.RuleModule): Rule.RuleModule {
 
 export const rule: Rule.RuleModule = {
   meta: generateMeta(meta, {
-    hasSuggestions: true,
     messages: {
       ...langRule.meta!.messages,
       ...decoratedHasLangRule.meta!.messages,

packages/jsts/src/rules/S6544/rule.ts

@@ -93,7 +93,6 @@ export const rule: Rule.RuleModule = {
       ...decoratedNoMisusedPromisesRule.meta!.messages,
       ...decoratedNoAsyncPromiseExecutorRule.meta!.messages,
     },
-    hasSuggestions: true,
     schema: [
       {
         type: 'object',

packages/jsts/src/rules/S6557/meta.ts

@@ -19,3 +19,4 @@ export const eslintId = 'prefer-string-starts-ends-with';
 export const externalRules = [
   { externalPlugin: 'typescript-eslint', externalRule: 'prefer-string-starts-ends-with' },
 ];
+export const quickFixMessage = 'Use startsWith() or endsWith()';

packages/jsts/src/rules/S6582/meta.ts

@@ -19,3 +19,4 @@ export const eslintId = 'prefer-optional-chain';
 export const externalRules = [
   { externalPlugin: 'typescript-eslint', externalRule: 'prefer-optional-chain' },
 ];
+export const quickFixMessage = 'Use optional chaining';

packages/jsts/src/rules/S6747/meta.ts

@@ -21,3 +21,4 @@ export const externalRules = [
   { externalPlugin: 'jsx-a11y', externalRule: 'aria-props' },
 ];
 export * from './config.js';
+export const quickFixMessage = 'Replace unknown property';

packages/jsts/src/rules/S6747/rule.ts

@@ -66,7 +66,8 @@ const twiceDecoratedNoUnknownProp = interceptReport(
 
 export const rule: Rule.RuleModule = {
   meta: generateMeta(meta, {
-    hasSuggestions: true,
+    ...decoratedAriaPropsRule.meta,
+    ...twiceDecoratedNoUnknownProp.meta,
     messages: {
       ...decoratedAriaPropsRule.meta!.messages,
       ...twiceDecoratedNoUnknownProp.meta!.messages,